Implements bsan_alloc and bsan_dealloc #16
Conversation
|
the pin to llvm probably has to be removed before merging. Because obraunsdorf/bsan_malloc is just for testing bsan_alloc using interceptors. |
| @@ -11,34 +11,65 @@ use crate::*; | |||
| /// of a singly-linked list. For this implementation to be sound, | |||
| /// the pointer that is returned must not be mutated concurrently. | |||
| pub unsafe trait Linkable<T: Sized> { | |||
| fn next(&self) -> *mut *mut T; | |||
| fn next(&mut self) -> *mut *mut T; | |||
There was a problem hiding this comment.
I think we should make the parameter something like node: *mut T instead of &mut self in case there's a situation where multiple threads could call this method. I don't think that's the case at the moment, since this should only be called in the critical section when we lock the free list, but I'm uncertain about the soundness of that w.r.t aliasing
| @@ -30,8 +30,11 @@ use crate::*; | |||
| #[derive(Debug)] | |||
| pub struct GlobalCtx { | |||
| hooks: BsanHooks, | |||
| // TODO(obraunsdorf): Does the counter need to be AtomicU64, because it would weaken security | |||
There was a problem hiding this comment.
It seems like 32-bit platforms don't have support for AtomicU64.
PowerPC and MIPS platforms with 32-bit pointers do not have
AtomicU64orAtomicI64types.1
Footnotes
| fn dealloc(&mut self, borrow_tag: TreeBorrows::BorrowTag) { | ||
| self.alloc_id = AllocId::invalid(); | ||
| self.tree_address.deallocate(self.base_addr(), borrow_tag); | ||
| //TODO(obraunsdorf) free the allocation of the tree itself |
There was a problem hiding this comment.
I think we should do that here; you could have dealloc take self.
| } | ||
| } | ||
|
|
||
| pub fn new_block<T>(&self, num_elements: NonZeroUsize) -> Block<T> { | ||
| pub(crate) unsafe fn allocate_lock_location(&self) -> NonNull<MaybeUninit<AllocMetadata>> { |
There was a problem hiding this comment.
I don't think this needs to be an unsafe function. Instead, you can propagate the option upward.
icmccorm
force-pushed
the
bsan
branch
3 times, most recently
from
220a58f to
81e1951
Compare
Implements #2