New feature and code improvement (v0.9.050) #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored `ConvertToType` in `DataController.cs` for better error handling and added support for `ObservableCollection<string>`. Introduced a new `EmojiCollection` setting and enhanced `LoadSettingFromXML` to retain existing values if missing or empty. Added `SetDefaultValue` method for default property values. Updated `SaveSettingToXML` to handle `ObservableCollection<string>` by serializing to JSON. Added extensive logging to settings management. In `OSCController.cs`, `GetNextEmoji` is now called with a `true` argument. Updated `PulsoidModule.cs` to check `Application.Current` before invoking `ProcessData` and refactored monitoring conditions into `CheckMonitoringConditions`. `PulsoidOAuthHandler` now implements `IDisposable` with proper resource disposal and improved error handling. Updated `MagicChatbox.csproj` to reference newer versions of `LibreHardwareMonitorLib` and `OpenAI-DotNet`. Added a new feature for custom prefix icon shuffle in personal status and chat messages. Introduced `EnableEmojiShuffle_checkbox` and related UI elements for emoji input and management. Updated `ViewModel` with properties and methods to handle emoji collection and shuffling logic. Removed outdated Halloween-themed UI elements and updated URLs in specific methods. Refactor settings and add custom emoji shuffle feature Refactored `ConvertToType` method for better error handling and added support for `ObservableCollection<string>`. Introduced a new `EmojiCollection` setting and updated `LoadSettingFromXML` and `SaveSettingToXML` methods to handle it. Added `SetDefaultValue` method and enhanced logging throughout settings management. Updated `GetNextEmoji` method to accept a boolean parameter. Refactored timer's elapsed event handler in `PulsoidModule.cs` and implemented `IDisposable` in `PulsoidOAuthHandler` with improved error handling and logging. Bumped versions of `LibreHardwareMonitorLib` and `OpenAI-DotNet` packages. Added custom prefix icon shuffle feature with new UI elements including a `CheckBox`, `TextBox`, and button for managing emoji list. Updated `ViewModel` to support new emoji shuffle settings and removed old Halloween-themed emojis. Updated UI and URLs in specific methods to reflect new features and changes.
Updated the version number in MagicChatbox.csproj from 0.9.047 to 0.9.050, indicating a new release or update with potential new features, bug fixes, or improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Classification
New feature and code improvement.
PR Summary
This PR introduces a custom prefix icon shuffle feature and improves error handling, logging, and default value management in the settings management process.
DataController.cs: RefactoredConvertToTypemethod and added support forObservableCollection<string>.PulsoidOAuthHandler: ImplementedIDisposableand added thread safety.ViewModel: Added properties and methods to manage the emoji collection and shuffle functionality.MainWindow.xaml.cs: Updated to handle new button click and key press events for adding emojis.