Skip to content

fix: require patched Node.js security releases - #22

Merged
roger-gan merged 1 commit into
mainfrom
fix/node-security-baseline
Oct 22, 2026
Merged

roger-gan merged 1 commit into
mainfrom
fix/node-security-baseline

Conversation

@roger-gan

@roger-gan roger-gan commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

CI uses Node.js 20, the package allows Node.js 18, and the wallet-cli JavaScript entrypoint checks only for Node.js 20 or newer. These requirements allow EOL runtimes and versions preceding the October 2026 security fixes.

Require ^22.23.4 || ^24.22.1 || >=26.12.1 for package runtime and development, and run CI on Node.js 24.22.1. Validate the full Node.js version before launching wallet-cli JavaScript entrypoints, rejecting unpatched, prerelease, and malformed versions. Preserve native executable behavior and update current documentation, steering, and the unreleased changelog.

Advisory: https://nodejs.org/en/blog/vulnerability/october-2026-security-releases

Verification

Using Node.js 22.23.4 and pnpm 10.0.0:

  • pnpm test: 347 passed; 2 existing real-CLI integration tests skipped.
  • pnpm lint, pnpm build, and pnpm test:cjs passed.
  • Added runtime version boundary, prerelease/malformed version, and native executable coverage.
  • git diff --check passed.

No dependency versions changed. The pnpm lockfile does not store root package engines and needs no update. Linux and Windows GitHub Actions checks remain pending.

@roger-gan
roger-gan merged commit c400138 into main Oct 22, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants