Repository navigation
fix: require patched Node.js security releases - #22
Merged
Merged
Conversation
boboliu-1010
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI uses Node.js 20, the package allows Node.js 18, and the wallet-cli JavaScript entrypoint checks only for Node.js 20 or newer. These requirements allow EOL runtimes and versions preceding the October 2026 security fixes.
Require
^22.23.4 || ^24.22.1 || >=26.12.1for package runtime and development, and run CI on Node.js 24.22.1. Validate the full Node.js version before launching wallet-cli JavaScript entrypoints, rejecting unpatched, prerelease, and malformed versions. Preserve native executable behavior and update current documentation, steering, and the unreleased changelog.Advisory: https://nodejs.org/en/blog/vulnerability/october-2026-security-releases
Verification
Using Node.js 22.23.4 and pnpm 10.0.0:
pnpm test: 347 passed; 2 existing real-CLI integration tests skipped.pnpm lint,pnpm build, andpnpm test:cjspassed.git diff --checkpassed.No dependency versions changed. The pnpm lockfile does not store root package engines and needs no update. Linux and Windows GitHub Actions checks remain pending.