Skip to content

Conversation

@apoelstra
Copy link
Collaborator

I didn't actually want to do the Elements benchmarks, but I guess I failed to filter the benchmarks, so here they are..

I didn't actually want to do the Elements benchmarks, but I guess I failed
to filter the benchmarks, so here they are..
Copy link
Collaborator Author

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On ab4e17e successfully ran local tests

@roconnor-blockstream
Copy link
Contributor

roconnor-blockstream commented Dec 9, 2025

Unfortunately these benchmarks are bad.

Firstly BuildTapbranch and TapdataInit indicating that there is still something wrong with how the Elements jet benchmarks are handled.

But the bigger issue is that there seems to be significant overhead in low cost jets.

Our calibration jet: CheckSigVerify is reasonably consistent: 55555 in 2024-07, 55137 in 2024-09, 54442 in 2025-10, 54916 and 54758 in this PR.

But the low cost jets have added significant overhead:

e.g. Eq1 was 41 in 2024-07, 43 in 2024-09, 36 in 2025-10, but now is 145 and 137 in this PR

Verify was 32 in 2024-07, 21 in 2024-09, 23 in 2025-10, but is now 96 and 136 in this PR.

@apoelstra
Copy link
Collaborator Author

Yep, you're right. I ran these with --debug on cargo criterion.

Will try again.

@apoelstra apoelstra closed this Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants