Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript and static types support to service #16

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Add TypeScript and static types support to service #16

wants to merge 26 commits into from

Conversation

Coinslist
Copy link

@Coinslist Coinslist commented Sep 8, 2022 •
edited
Loading

Summary

  1. Add TypeScript support with adjustable compiler options inside service/tsconfig.json file
  2. Add appropriate types for service/

@Coinslist
Add tsconfig.json file
f332373
@Coinslist
add tsconfig.json file
485fb28
@Coinslist
Add TypeScript type definitions for dependencies
baecbe2
@Coinslist
update service start script to node dist/server.js`
31c331d
@Coinslist
Add static typing to controllers/BalanceController
291d657
@Coinslist
add static types to controllers/SubmitController
de6116a
@Coinslist
Add static types to controllers/IndexController
bd22c83
@Coinslist
Add static types to src/server and src/app implementation
b881b10
@Coinslist
Add static types to models/Conversion
691b701
@Coinslist
Add static types to models/Data
027bbee
@Coinslist
Add static types to models/Transaction
bb865b2
@Coinslist
Add static types to models/Transfer
9b4228b
@Coinslist
Add static types to modules/bsc
0a09bc5
@Coinslist
Add static types to modules/chores
248fc40
@Coinslist
Add static types to modules/data
678786d
@Coinslist
Add static types to modules/db
cf8228b
@Coinslist
Add static types to modules/rpc
ea9b718
@Coinslist
Add static types to modules/web3
8b63ccf
@Coinslist
Add static types to modules
621f1c9
@Coinslist
Add static types to utils/config
ba5ba13
@Coinslist
Add static types to utils/
074d6c8
@Coinslist
add globally shared types for /service
58849f1
@Coinslist
add appropriate type for models/Conversion
81e4034
@Coinslist
Fix type on models/Transaction model
8b4cbf5
@Coinslist
Fix models/Conversion type
b03a3ee
@Coinslist
Fix modules/web3.ts class Web3Base, make confirmations member p…
65313eb 
…ublic
@gitcoinbot gitcoinbot mentioned this pull request Sep 8, 2022
Open
@Coinslist
Copy link
Author

Hi @wu-emma
Please have a look at this (#16)

Thanks

@naftalimurgor
Copy link

Hey @Coinslist

  • add npm script to transpile the TypeScript to JavaScript
  • Update Dockerfile for /service
  • Add coverage/ensure all tests pass
    Afterwards we shall review @wu-emma what are your views?

@wu-emma
Copy link
Contributor

wu-emma commented Feb 6, 2023

Ok, guys, please resolve merge conflicts, and then ping @van-orton if he would be able to test 'Typescripted'-bridge. Thanks for moving this forward!

@naftalimurgor
Copy link

@Coinslist @wu-emma
Awsome. We are on it!

@naftalimurgor naftalimurgor mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Coinslist @naftalimurgor @wu-emma