feat(descriptor): add ext_check to validate descriptors with extra params #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rams Adds check for extended descriptor parameters. Available in `ext_check()` where OP_DROP and other features can be opted in. Issue: opdrop.add_ext_check
Remove redundant references and string conversions in ext_check implementations for Descriptor types. Issue: opdrop.add_ext_check
OttoAllmendinger
force-pushed
the
opdrop.add_ext_check
branch
from
ca928da to
d01d435
Compare
|
note that the failing checks are lint errors |
saravanan7mani
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds check for extended descriptor parameters. Available in
ext_check()where OP_DROP and other features can be opted in.Issue: opdrop.add_ext_check