-
Notifications
You must be signed in to change notification settings - Fork 21
feat(opentelemetry): create otel instrumentation for typed-express-router #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ericcrosson-bitgo
merged 1 commit into
beta
from
DX-1473-create-otel-wrapper-for-typed-express-router
Jul 18, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,22 @@ | ||
import express from 'express'; | ||
import { Errors } from 'io-ts'; | ||
import * as PathReporter from 'io-ts/lib/PathReporter'; | ||
|
||
export function defaultOnDecodeError( | ||
errs: Errors, | ||
_req: express.Request, | ||
res: express.Response, | ||
) { | ||
const validationErrors = PathReporter.failure(errs); | ||
const validationErrorMessage = validationErrors.join('\n'); | ||
res.status(400).json({ error: validationErrorMessage }).end(); | ||
} | ||
import type { | ||
DecodeErrorFormatterFn, | ||
EncodeErrorFormatterFn, | ||
GetDecodeErrorStatusCodeFn, | ||
GetEncodeErrorStatusCodeFn, | ||
} from './types'; | ||
|
||
export function defaultOnEncodeError( | ||
err: unknown, | ||
_req: express.Request, | ||
res: express.Response, | ||
) { | ||
res.status(500).end(); | ||
console.warn(`Error in route handler: ${err}`); | ||
} | ||
export const defaultDecodeErrorFormatter: DecodeErrorFormatterFn = PathReporter.failure; | ||
|
||
export const defaultGetDecodeErrorStatusCode: GetDecodeErrorStatusCodeFn = ( | ||
_err, | ||
_req, | ||
) => 400; | ||
|
||
export const defaultEncodeErrorFormatter: EncodeErrorFormatterFn = () => ({}); | ||
|
||
starfy84 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
export const defaultGetEncodeErrorStatusCode: GetEncodeErrorStatusCodeFn = ( | ||
_err, | ||
_req, | ||
) => 500; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.