fix(sdk-coin-ada): rejecting ada outputs below 1 ADA#8283
Open
fix(sdk-coin-ada): rejecting ada outputs below 1 ADA#8283
Conversation
| // Native coin send | ||
| // Native coin send — reject if below Cardano's minimum output (BabbageOutputTooSmallUTxO) | ||
| const amount = CardanoWasm.BigNum.from_str(receiverAmount); | ||
| if (amount.less_than(CardanoWasm.BigNum.from_str(MIN_ADA_TRANSFER))) { |
Contributor
There was a problem hiding this comment.
do we need this exception for if change.less_than(CardanoWasm.BigNum.from_str(MIN_ADA_TRANSFER))) as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CSHLD-459
Description:
ADA transactions with output amounts less than 1ADA used to get stuck in the sendqueue.
Fix:
Added validation in the ADA transaction builder to enforce the Cardano protocol minimum of 1 ADA per output:
Testing
All (164) unit tests passing. New tests cover the boundary conditions (999,999 lovelace rejected, 1,000,000 lovelace allowed, dust change absorbed, sub-1-ADA consolidation rejected).