feat(statics): add polyx tokens #7143
Conversation
| UnderlyingAsset['tpolyx:RAND176TM'], | ||
| POLYX_TOKEN_FEATURES | ||
| ), | ||
| polyxToken( |
There was a problem hiding this comment.
Based on existing patterns we first write prod token followed by test tokens
There was a problem hiding this comment.
Thanks for making changes
| ), | ||
| polyxToken( | ||
| '4121c583-2e0f-4d4c-95de-24b2a3f77181', | ||
| 'tpolyx:0xa0ce6bc4c60981e08eca6504656c99e6', |
There was a problem hiding this comment.
why is here 'tpolyx:0xa0ce6bc4c60981e08eca6504656c99e6', it should be polyx:0xa0ce6bc4c60981e08eca6504656c99e6? it is a prod token right
There was a problem hiding this comment.
nice catch. Addressed it. Thanks
| 'tpolyx:0xa0ce6bc4c60981e08eca6504656c99e6', | ||
| 'RAND175TM', | ||
| 6, | ||
| '', |
There was a problem hiding this comment.
why is the '' can't we write 'RAND175TM', suggested based on existing patterns?
There was a problem hiding this comment.
The ticker field is specific to the polyxToken and can be optional.
For this particular token, it’s empty on-chain, so we’re keeping it the same here as well.
https://polymesh.protofire.io/asset/0xa0ce6bc4c60981e08eca6504656c99e6
There was a problem hiding this comment.
Not sure about this, please once check with @MohammedRyaan786 , rest LGTM
nvrakesh06
dismissed stale reviews from ravibitgo and MohammedRyaan786
via
bac6423
nvrakesh06
requested review from
damodarnaik699,
MohammedRyaan786 and
ravibitgo
| UnderlyingAsset['tpolyx:RAND176TM'], | ||
| POLYX_TOKEN_FEATURES | ||
| ), | ||
|
|
There was a problem hiding this comment.
Nit: why this line space empty
TICKET: WIN-7452