feat(utxo-core): add verification func for to_sign txs #6718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add function to verify BIP322 to_sign transaction structure and that inputs reference the correct to_spend transactions for given addresses and messages. Includes test coverage for verifying multiple messages. BTC-2375 Co-authored-by: llm-git <[email protected]> TICKET: BTC-2375
OttoAllmendinger
requested changes
Aug 18, 2025
| * @param verificationInfo | ||
| * @param network | ||
| */ | ||
| export function verifyFixedScriptToSignTxWithInfo( |
There was a problem hiding this comment.
per convention, void funcs that throw are prefixed with assert
Suggested change
| export function verifyFixedScriptToSignTxWithInfo( | |
| export function assertValidFixedScriptToSignTxWithInfo( |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to verify BIP322 to_sign transaction structure and that inputs reference the correct to_spend transactions for given addresses and messages. Includes test coverage for verifying multiple messages.
TICKET: BTC-2375