refactor(account-lib): use Signature type #6389
Draft
+1,124
−82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features to the SDK, focusing on improvements to message handling and support for the CIP8 standard. Key changes include adding support for serialized signatures in EIP-191 messages, implementing the CIP8 message standard for Cardano, and extending the test suite to cover these updates.
Enhancements to EIP-191 Message Handling:
Eip191MessageBuilder
to handle serialized signatures by integratingdeserializeSignatures
and modifying thefromBroadcastFormat
method. [1] [2]fixtures
and methods for adding, replacing, and broadcasting signatures. [1] [2] [3] [4] [5] [6] [7]fixtures
to use structured signature objects, ensuring consistency with the new serialized signature format.Introduction of CIP8 Standard for Cardano:
Cip8Message
class to handle CIP8 message creation, validation, and signing, leveraging Cardano serialization libraries and CBOR encoding.Cip8MessageBuilder
to construct and parse CIP8 messages, including support for serialized signatures.utils.ts
for constructing COSE objects and encoding/decoding operations.Testing and Resources for CIP8:
cip8Resources.ts
to provide test data, including addresses, keys, and precomputed signatures for CIP8 messages.Miscellaneous Updates:
.gitcommitscopes
to includesdk-coin-ada
, reflecting the new module for Cardano CIP8 support.TICKET: COIN-4724