Skip to content

refactor(account-lib): use Signature type #6389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bhavidhingra
Copy link
Contributor

@bhavidhingra bhavidhingra commented Jul 3, 2025

This pull request introduces several enhancements and new features to the SDK, focusing on improvements to message handling and support for the CIP8 standard. Key changes include adding support for serialized signatures in EIP-191 messages, implementing the CIP8 message standard for Cardano, and extending the test suite to cover these updates.

Enhancements to EIP-191 Message Handling:

  • Serialized Signatures Support: Updated Eip191MessageBuilder to handle serialized signatures by integrating deserializeSignatures and modifying the fromBroadcastFormat method. [1] [2]
  • Test Updates for EIP-191: Adjusted tests to validate serialized signatures, including changes to fixtures and methods for adding, replacing, and broadcasting signatures. [1] [2] [3] [4] [5] [6] [7]
  • Fixture Adjustment: Updated fixtures to use structured signature objects, ensuring consistency with the new serialized signature format.

Introduction of CIP8 Standard for Cardano:

  • CIP8 Message Implementation: Added Cip8Message class to handle CIP8 message creation, validation, and signing, leveraging Cardano serialization libraries and CBOR encoding.
  • CIP8 Message Builder: Created Cip8MessageBuilder to construct and parse CIP8 messages, including support for serialized signatures.
  • Utility Functions: Developed helper functions in utils.ts for constructing COSE objects and encoding/decoding operations.
  • Message Builder Factory: Extended the factory to include support for CIP8 message builders.

Testing and Resources for CIP8:

  • Test Resources: Added cip8Resources.ts to provide test data, including addresses, keys, and precomputed signatures for CIP8 messages.
  • Module Index Updates: Updated index files to export new CIP8-related classes and utilities. [1] [2]

Miscellaneous Updates:

  • Scope Addition: Updated .gitcommitscopes to include sdk-coin-ada, reflecting the new module for Cardano CIP8 support.

TICKET: COIN-4724

@bhavidhingra bhavidhingra force-pushed the coin-4724-ada-message-buider branch 2 times, most recently from 7c9360a to 7478975 Compare July 3, 2025 13:40
@bhavidhingra bhavidhingra force-pushed the coin-4724-ada-message-buider branch 3 times, most recently from e9ff19c to 55b8778 Compare July 3, 2025 15:51
@bhavidhingra bhavidhingra force-pushed the coin-4724-ada-message-buider branch from 55b8778 to 774d38f Compare July 3, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant