Skip to content

feat(utxo-bin): allow imports from utxo-core and noble/curves #6387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat(utxo-bin): allow imports from utxo-core and noble/curves #6387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c35de53
feat(utxo-bin): allow imports from utxo-core and noble/curves
OttoAllmendinger Jul 2, 2025
1fb3f6f
ci: drop Node.js 18.x from package update workflow
OttoAllmendinger Jul 4, 2025
205512e
chore: do not remove lockfile in test_package_updates workflow
OttoAllmendinger Jul 4, 2025
3391908
feat(deser-lib): fix import path in tests
OttoAllmendinger Jul 4, 2025
e61dce7
fix(ci): update yarn install command syntax
OttoAllmendinger Jul 4, 2025
9954cbc
feat(.github): update CI to run all tests when package.json changes
OttoAllmendinger Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,24 @@ jobs:
DISABLE_V8_COMPILE_CACHE: '1'
run: yarn run postinstall

- name: Check for package.json changes
id: changed-package-json
uses: tj-actions/changed-files@v44
with:
files: |
**/package.json
files_ignore: |
**/node_modules/**

- name: Unit Test
run: yarn run unit-test-changed
run: |
if [[ "${{ steps.changed-package-json.outputs.any_changed }}" == "true" ]]; then
echo "Running all unit tests because a package.json file changed."
yarn run unit-test
else
echo "Running changed unit tests."
yarn run unit-test-changed
fi
env:
BITGOJS_TEST_PASSWORD: ${{ secrets.BITGOJS_TEST_PASSWORD }}

Expand Down Expand Up @@ -208,7 +224,7 @@ jobs:

- name: Install Packages
if: steps.lerna-cache.outputs.cache-hit != 'true' || contains( github.event.pull_request.labels.*.name, 'SKIP_CACHE')
run: yarn install --with-frozen-lockfile
run: yarn install --frozen-lockfile

- name: build packages
if: steps.lerna-cache.outputs.cache-hit == 'true'
Expand Down
56 changes: 0 additions & 56 deletions .github/workflows/test_package_updates.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion modules/deser-lib/test/unit/deser-lib.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Cbor } from '../..';
import { Cbor } from '../../src';
import * as cborFixtures from '../cbor/fixtures.json';

describe('deser-lib', function () {
Expand Down
11 changes: 11 additions & 0 deletions modules/utxo-bin/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,17 @@
"extends": "../../.eslintrc.json",
"rules": {
"@typescript-eslint/explicit-module-boundary-types": "error",
"import/no-internal-modules": [
"error",
{
// these are false-positives
// certain packages explicitly ALLOW deep imports via the `exports` directive in package.json
"allow": [
"@bitgo/utxo-core/*",
"@noble/curves/*"
]
}
],
"indent": "off"
}
}
1 change: 1 addition & 0 deletions modules/utxo-bin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"@bitgo/blockapis": "^1.10.18",
"@bitgo/statics": "^54.5.0",
"@bitgo/unspents": "^0.48.3",
"@bitgo/utxo-core": "^1.11.0",
"@bitgo/utxo-lib": "^11.6.1",
"@bitgo/wasm-miniscript": "2.0.0-beta.7",
"@noble/curves": "1.8.1",
Expand Down
Loading