fix(sdk-coin-sol): fix ata creation for sol 2022 token #6201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekagrawal080
force-pushed
the
WIN-5670
branch
3 times, most recently
from
f70320d to
c019ad6
Compare
abhishekagrawal080
force-pushed
the
WIN-5670
branch
2 times, most recently
from
8f84dd4 to
8c6791a
Compare
veetragjain
reviewed
May 29, 2025
modules/statics/src/account.ts
Outdated
| contractAddress: string, | ||
| asset: UnderlyingAsset, | ||
| features: CoinFeature[] = [...AccountCoin.DEFAULT_FEATURES, CoinFeature.REQUIRES_RESERVE], | ||
| programId = '', |
Contributor
There was a problem hiding this comment.
Why not default it to spl token program id, instead of having an empty string.
abhishekagrawal080
force-pushed
the
WIN-5670
branch
from
8c6791a to
5e4f561
Compare
abhishekagrawal080
force-pushed
the
WIN-5670
branch
3 times, most recently
from
e04b6fa to
c879d2c
Compare
veetragjain
previously approved these changes
May 29, 2025
modules/statics/src/base.ts
Outdated
Comment on lines
2706
to
2710
| export enum ProgramID { | ||
| TokenProgramId = 'TokenkegQfeZyiNwAJbNbGKPFXCWuBvf9Ss623VQ5DA', | ||
| Token2022ProgramId = 'TokenzQdBNbLqP5VEhdkAS6EPFLC1PHnBqCXEpPxuEb', | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Nit: This can reside in account.ts file, base.ts have enums and types that are required by baseCoin class. Can you please also add a description for this enum.
| const tokensArray = tokens.map((token) => token); | ||
| if (tokensArray.length >= 1) { | ||
| // there should never be two tokens with the same contract address, so we assert that here | ||
| assert(tokensArray.length === 1); |
Contributor
There was a problem hiding this comment.
Please verify if we have any testnet and mainnet token with same contract address. This check will fail in that case.
Contributor
Author
There was a problem hiding this comment.
I have checked there is no token with same address in testnet and mainnet
abhishekagrawal080
force-pushed
the
WIN-5670
branch
from
c879d2c to
4acffc6
Compare
veetragjain
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: WIN-5670