Skip to content

fix(sdk-coin-hbar): Fix thbar usdc token id #6160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ranjna-G merged 1 commit into from
May 23, 2025
Merged

fix(sdk-coin-hbar): Fix thbar usdc token id #6160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/sdk-coin-hbar/test/fixtures/hbar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
export const rawTransactionForExplain =
'{"txHex":"224a0a140a0c0888cb98fb0510d2a8d3b20212041895d2021202180418d7e9462202087872260a240a100a08080010001895d20210ffd78ab2100a100a08080010001893d2021080d88ab210","txInfo":{"id":"[email protected]","hash":"987d0a89b58fbcc988f2cf00bcac1c0126db0ef4a8634dcc42fa3b38a2c9092e73c57b794938d82e75feb6d04f8d4f33","data":"0a140a0c0888cb98fb0510d2a8d3b20212041895d2021202180418d7e9462202087872260a240a100a08080010001895d20210ffd78ab2100a100a08080010001893d2021080d88ab210","fee":1160407,"from":"0.0.43285","startTime":"1600529800.643093586","validDuration":"120","node":"0.0.4","memo":"","amount":"2200000000","to":"0.0.43283"},"feeInfo":{"size":1000,"fee":1160407,"feeRate":1160407},"recipients":[{"amount":"2200000000","address":"0.0.43283","recipientLabel":null,"memo":{"type":"id","value":"1"}}],"walletId":"5f64df896fe0d400126128ca1e0942ea","walletContractAddress":"0.0.43285","amount":"2200000000","address":"0.0.43283","receivedCoin":{"name":"thbar","svg":"hbar","family":"hbar","modifier":100000000,"modifierExp":8,"fullDisplay":"Testnet Hedera HBAR","shortDisplay":"THBAR","hasMarketData":true,"hasTokens":false},"coin":"thbar","memo":{"type":"id","value":"1"}}';
export const UNSIGNED_TOKEN_TRANSFER =
'22570a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401722712250a0708001000189666120c0a080800100018a8fb041013120c0a080800100018d5d0041014';
'22580a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401722812260a080800100018da991a120c0a080800100018a8fb041013120c0a080800100018d5d0041014';
export const UNSIGNED_MULTI_TRANSFER =
'225c0a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401722c0a2a0a0c0a080800100018a8fb0410310a0c0a080800100018d5d00410140a0c0a080800100018f3e804101e';
export const UNSIGNED_TOKEN_MULTI_TRANSFER =
'22650a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401723512330a0708001000189666120c0a080800100018a8fb041031120c0a080800100018d5d0041014120c0a080800100018f3e804101e';
'22660a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401723612340a080800100018da991a120c0a080800100018a8fb041031120c0a080800100018d5d0041014120c0a080800100018f3e804101e';
export const UNSIGNED_TOKEN_ASSOCIATE =
'22440a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401c202130a080800100018a8fb04120708001000189666';
'22450a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401c202140a080800100018a8fb0412080800100018da991a';
16 changes: 8 additions & 8 deletions modules/sdk-coin-hbar/test/resources/hbar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,28 +115,28 @@ export const WALLET_INIT_2_OWNERS =
'227f0a140a0c089ded8af90510aac5d8b101120418d5d00412021804188094ebdc03220208785a590a4e2a4c080212480a2212205a9111b5e6881ff20b9243a42ac1a9a67fa16cd4f01e58bab30c1fe611ea8cf90a221220592a4fbb7263c59d450e651df96620dc9208ee7c7d9d6f2fdcb91c53f883126110004a0508d0c8e103';

export const SIGNED_TOKEN_TRANSFER_TRANSACTION =
'1a660a640a205a9111b5e6881ff20b9243a42ac1a9a67fa16cd4f01e58bab30c1fe611ea8cf91a40e95fc3e84baf05107545edeb29e5d784438312f1dca1677f637e40890afd966c563452cb2484b09435cf3bfe754b46ab30488e871541fd31535f4234383ff40622570a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401722712250a0708001000189666120c0a080800100018a8fb041013120c0a080800100018d5d0041014';
'1a660a640a205a9111b5e6881ff20b9243a42ac1a9a67fa16cd4f01e58bab30c1fe611ea8cf91a40b3ca41d1ed567a6c52ae901f5dd924d00cbc3dfea938b0aed1e0fd1902a3bd0a5b4850d223d3a2226cbe18dc0a2aae7582eea33c1318f57e16904de3545e6c0d22580a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401722812260a080800100018da991a120c0a080800100018a8fb041013120c0a080800100018d5d0041014';

export const NON_SIGNED_TOKEN_TRANSFER_TRANSACTION =
'22570a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401722712250a0708001000189666120c0a080800100018a8fb041013120c0a080800100018d5d0041014';
'22580a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401722812260a080800100018da991a120c0a080800100018a8fb041013120c0a080800100018d5d0041014';

export const SIGNED_TOKEN_MULTI_TRANSFER_TRANSACTION =
'22670a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401723712350a090800100018d3fa8a01120c0a080800100018a8fb041031120c0a080800100018d5d0041014120c0a080800100018f3e804101e';

export const NON_SIGNED_TOKEN_MULTI_TRANSFER_TRANSACTION =
'22650a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401723512330a0708001000189666120c0a080800100018a8fb041031120c0a080800100018d5d0041014120c0a080800100018f3e804101e';
'22660a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401723612340a080800100018da991a120c0a080800100018a8fb041031120c0a080800100018d5d0041014120c0a080800100018f3e804101e';

export const NON_SIGNED_TOKEN_MULTI_TRANSFER_TRANSACTION_SERIALIZED =
'1a660a640a205a9111b5e6881ff20b9243a42ac1a9a67fa16cd4f01e58bab30c1fe611ea8cf91a40ca950014c83f91a241a91b1dd7e9322bdfa3e0e5ef79a9d299f81ac68f4349352ad6f363bc0f5a4696225315748550f381ac6acf9bf5b88701c93f157d35890d22650a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401723512330a0708001000189666120c0a080800100018a8fb041031120c0a080800100018d5d0041014120c0a080800100018f3e804101e';
'1a660a640a205a9111b5e6881ff20b9243a42ac1a9a67fa16cd4f01e58bab30c1fe611ea8cf91a408d5a5a149aa3b842fc2bff25dbe932782ebb0f5db7770bc34c72dbf07f6abfa5485045efd86dad13f66673e0769462ddc61b49f9c24f3f2c69fa7c559459230422660a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401723612340a080800100018da991a120c0a080800100018a8fb041031120c0a080800100018d5d0041014120c0a080800100018f3e804101e';

export const THREE_TIMES_SIGNED_TOKEN_TRANSACTION =
'1ab2020a640a205a9111b5e6881ff20b9243a42ac1a9a67fa16cd4f01e58bab30c1fe611ea8cf91a40ae49b7e9e4d75bcc8d485a77b79d3b3690708309dfe7f59bd3a4130ea849a592da3e3a299334bbff9379db50f35f82962a46afc4b09b3304245d9e274f25f3080a640a20592a4fbb7263c59d450e651df96620dc9208ee7c7d9d6f2fdcb91c53f88312611a40eb7092cc8c84630ea28df3d4dd1fdb136dcaab9edaad7a93cfedfa3baecdedd60a85019fc564cb7b3b36e2ae7f0f49717a71d9b3bcaf42e90d1e2b391cd6570c0a640a20fa344793601cef71348f994f30a168c2dd55f357426a180a5a724d7e03585e911a4092527012381c88e29b440a565b0402ed9e2717399145ad6ca711f7b6d4abc42eb42fcedc68dab59ec106bed6b1e6bd1cf2cd49b9d3ac5f0afb40b56f154b260822560a180a0c089ded8af90510aac5d8b10112080800100018a8fb041206080010001804188094ebdc03220308b401722712250a0708001000189666120c0a080800100018a8fb041013120c0a080800100018d5d0041014';
'1ab2020a640a205a9111b5e6881ff20b9243a42ac1a9a67fa16cd4f01e58bab30c1fe611ea8cf91a40632b595ee568ca06824993f94fcad8db33189e1838cd390712159627bd9d0d8ec78712ff7e975c5c695bce96d80ede288d3d05752b0b7aea868ce5dd5f16c00f0a640a20592a4fbb7263c59d450e651df96620dc9208ee7c7d9d6f2fdcb91c53f88312611a403cb28488655ac9218a7964a1990247756390bb1faddee11f65cc4d6fc9dd3db331fcd211905611b7589ad3fedde87e6361260494903acdb5a45b19580a06f10c0a640a20fa344793601cef71348f994f30a168c2dd55f357426a180a5a724d7e03585e911a40049392a214f70e2cca8f58d652eeb64f0161d6d7f7a4972d07cfe2513f555338df1cd0be95bb85951f6bf20f16fc44680fefc921fcd4fbb54e9bc5ae3a212d0322570a180a0c089ded8af90510aac5d8b10112080800100018a8fb041206080010001804188094ebdc03220308b401722812260a080800100018da991a120c0a080800100018a8fb041013120c0a080800100018d5d0041014';

export const SIGNED_TOKEN_ASSOCIATE_TRANSACTION =
'1a660a640a205a9111b5e6881ff20b9243a42ac1a9a67fa16cd4f01e58bab30c1fe611ea8cf91a4065282aa2df548eee1086780a8e7ea819b022fa220006e5c155b1e7af0a7cbae340722f8eba1b405fc004817d9a25cc33df55b93820abf900198981ebf6d6210222440a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401c202130a080800100018a8fb04120708001000189666';
'1a660a640a205a9111b5e6881ff20b9243a42ac1a9a67fa16cd4f01e58bab30c1fe611ea8cf91a40acf1576d775563529a074834a60f495526da3e32881ebc01a4ad93371a73b04f483f6a3731514ff7899387246ddafb1c1401cb4c01d0921256ce20b04b1b470122450a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401c202140a080800100018a8fb0412080800100018da991a';

export const NON_SIGNED_TOKEN_ASSOCIATE_TRANSACTION =
'22440a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401c202130a080800100018a8fb04120708001000189666';
'22450a180a0c089ded8af90510aac5d8b10112080800100018a8fb0412070800100018a912188094ebdc03220308b401c202140a080800100018a8fb0412080800100018da991a';

export const THREE_TIMES_SIGNED_TOKEN_ASSOCIATE_TRANSACTION =
'1ab2020a640a205a9111b5e6881ff20b9243a42ac1a9a67fa16cd4f01e58bab30c1fe611ea8cf91a4098bbf00ea401695033f13480d676283528dfc5d66a2cf773f46266c1fe6766ea6638d46d1f443fdfd327500b02fdf90fc7ad822deb4fb052a5ab1e3ff9e9e60a0a640a20592a4fbb7263c59d450e651df96620dc9208ee7c7d9d6f2fdcb91c53f88312611a402d9fb64718e85831908edeabf9adb0f832756f5d64e254958c91a115f3948f3d39b29aa0a2241755953792cad7e3ce8173b5417e87de6727697285a0ee6e230a0a640a20fa344793601cef71348f994f30a168c2dd55f357426a180a5a724d7e03585e911a407a0a04aa1fc7844e4525b93684035f19beca67ff53286705ade0dd72e2c03717207daedfa1c70b261f6e802f968f68419d3095a4e64ad14dfbbb02ea27bdf00422430a180a0c089ded8af90510aac5d8b10112080800100018a8fb041206080010001804188094ebdc03220308b401c202130a080800100018a8fb04120708001000189666';
'1ab2020a640a205a9111b5e6881ff20b9243a42ac1a9a67fa16cd4f01e58bab30c1fe611ea8cf91a403c4c86d35bbd3fccdb97137d16b60c3d774c5a51dff18100040fb509f72d230a352944553ac001046d79e9e99e6245bfbfea495dcf0c76b63d497ba69e9e560a0a640a20592a4fbb7263c59d450e651df96620dc9208ee7c7d9d6f2fdcb91c53f88312611a4044b5522c474953de2e08ea4df4d2d6a2f437f4014a9467bc0c11de9913d4630da5eb9a7f98c08de4aad07e5c4a3cba092958df8059b5b4c9c68e0f74117f69050a640a20fa344793601cef71348f994f30a168c2dd55f357426a180a5a724d7e03585e911a40c847b91651c95a47fb3b6e776e421645df7b5a6ebbc328701b204f7e0648c7199d2345f5bb85b422400bc1f18111409e70e346dec14c7e2e5592c89d5bda1b0c22440a180a0c089ded8af90510aac5d8b10112080800100018a8fb041206080010001804188094ebdc03220308b401c202140a080800100018a8fb0412080800100018da991a';
2 changes: 1 addition & 1 deletion modules/sdk-coin-hbar/test/unit/hbar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,7 @@ describe('Hedera Hashgraph:', function () {
const balance = '1000000000';
const formatBalanceResponse = (balance: string) =>
new BigNumber(balance).dividedBy(basecoin.getBaseFactor()).toFixed(9) + ' ℏ';
const tokenId = '0.0.13078';
const tokenId = '0.0.429274';

describe('Non-BitGo', async function () {
const sandBox = Sinon.createSandbox();
Expand Down
4 changes: 2 additions & 2 deletions modules/sdk-coin-hbar/test/unit/hbarToken.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ describe('Hedera Hashgraph Token', function () {
token.network.should.equal('Testnet');
token.decimalPlaces.should.equal(6);
token.nodeAccountId.should.equal('0.0.3');
token.tokenId.should.equal('0.0.13078');
token.contractAddress.should.equal('0.0.13078');
token.tokenId.should.equal('0.0.429274');
token.contractAddress.should.equal('0.0.429274');
token.tokenId.should.equal(token.contractAddress);
});
});
2 changes: 1 addition & 1 deletion modules/sdk-coin-hbar/test/unit/transactionBuilder/tokenAssociateBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ describe('HBAR Token Associate Builder', () => {
txBuilder.tokens('thbar:usdc');
assert.throws(
() => txBuilder.tokens('thbar:usdc'),
(e: any) => e.message === 'Repeated token ID: 0.0.13078'
(e: any) => e.message === 'Repeated token ID: 0.0.429274'
);
});

Expand Down
2 changes: 1 addition & 1 deletion modules/statics/src/coins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1571,7 +1571,7 @@ export const coins = CoinMap.fromCoins([
Networks.test.hedera,
6,
UnderlyingAsset.USDC,
'0.0.13078',
'0.0.429274',
AccountCoin.DEFAULT_FEATURES
),
hederaToken(
Expand Down
8 changes: 4 additions & 4 deletions modules/statics/test/unit/resources/amsTokenConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,8 @@ export const amsTokenConfig = {
},
primaryKeyCurve: 'ed25519',
nodeAccountId: '0.0.3',
tokenId: '0.0.13078',
contractAddress: '0.0.13078',
tokenId: '0.0.429274',
contractAddress: '0.0.429274',
},
],
'tavaxc:bitgo': [
Expand Down Expand Up @@ -723,8 +723,8 @@ export const incorrectAmsTokenConfig = {
},
primaryKeyCurve: 'ed25519',
nodeAccountId: '0.0.3',
tokenId: '0.0.13078',
contractAddress: '0.0.13078',
tokenId: '0.0.429274',
contractAddress: '0.0.429274',
},
],
};
Expand Down