Skip to content

Conversation

@abhijit0943
Copy link
Contributor

TICKET: SC-1836

@abhijit0943 abhijit0943 changed the title feat: add batchUnstakingBuilder and withdrawUnbondedBuilder feat: add batchUnstakingBuilder and withdrawUnbondedBuilder to support unstaking in polyx May 19, 2025
@abhijit0943 abhijit0943 marked this pull request as ready for review May 21, 2025 14:30
@abhijit0943 abhijit0943 requested a review from a team as a code owner May 21, 2025 14:30
@mullapudipruthvik mullapudipruthvik requested a review from Copilot May 28, 2025 03:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements new transaction builders to support unstaking in Polyx by introducing a BatchUnstakingBuilder and a WithdrawUnbondedBuilder along with corresponding unit tests and schema validations. Key changes include:

  • Addition of unit tests and implementation for withdraw unbonded transactions.
  • Introduction of the batch unstaking transaction builder with atomic execution.
  • Updates to the transaction builder factory and export index to include the new builders.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
modules/sdk-coin-polyx/test/unit/transactionBuilder/withdrawUnbondedBuilder.ts Unit tests for the withdraw unbonded builder.
modules/sdk-coin-polyx/test/unit/transactionBuilder/batchUnstakingBuilder.ts Unit tests for the batch unstaking builder.
modules/sdk-coin-polyx/test/resources/index.ts Added raw transaction resources for new unstaking transactions.
modules/sdk-coin-polyx/src/lib/withdrawUnbondedBuilder.ts Implementation and validation for withdraw unbonded builder.
modules/sdk-coin-polyx/src/lib/txnSchema.ts Added schema validations for both new builders.
modules/sdk-coin-polyx/src/lib/transactionBuilderFactory.ts Extended factory to return new unstaking builders.
modules/sdk-coin-polyx/src/lib/index.ts Re-exported the new builders.
modules/sdk-coin-polyx/src/lib/iface.ts Defined interfaces for unstaking transaction arguments.
modules/sdk-coin-polyx/src/lib/batchUnstakingBuilder.ts Implementation and validation for batch unstaking builder.

@abhijit0943 abhijit0943 merged commit cb96486 into master Jun 5, 2025
12 checks passed
@abhijit0943 abhijit0943 deleted the SC-1836 branch June 5, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants