Skip to content

feat(sdk-coin-vet): add sdk skeleton for vet #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohitkh7
Copy link
Contributor

@mohitkh7 mohitkh7 commented May 19, 2025

This pull request introduces support for the VeChain (vet) and Testnet VeChain (tvet) coins in the BitGo SDK. It includes updates to the codebase to register these coins, as well as the addition of a new module, sdk-coin-vet, which contains the implementation for these coins.

VeChain (vet) Integration:

Codebase Updates:

  • Code Ownership: Added sdk-coin-vet to the CODEOWNERS file, assigning ownership to the @BitGo/ethalt-team.
  • Dockerfile: Updated to include sdk-coin-vet in the build process and dependency linking. [1] [2] [3]

Package Updates:

  • Dependencies: Added @bitgo/sdk-coin-vet to the modules/bitgo/package.json file.
  • TypeScript Config: Included sdk-coin-vet in the tsconfig.json file for proper TypeScript support.

Coin Registration:

  • Coin Factory: Registered vet and tvet in the coinFactory.ts file for proper initialization. [1] [2] [3]
  • Exports: Updated index.ts to export Vet and Tvet classes. [1] [2]

New Module: sdk-coin-vet

Configuration and Metadata:

  • Added configuration files such as .eslintignore, .gitignore, .mocharc.yml, .npmignore, .prettierignore, and .prettierrc.yml for linting, formatting, and testing. [1] [2] [3] [4] [5] [6]
  • Created a README.md file documenting the purpose, installation, and development guidelines for sdk-coin-vet.
  • Added a package.json file defining the package's metadata, dependencies, and scripts.

Core Implementation:

  • Entry Point: Added index.ts to export core modules (lib, vet, tvet, register).
  • Constants: Defined DEFAULT_GAS_UNIT_PRICE in constants.ts.
  • Utilities: Implemented a Utils class with placeholder methods for validation in utils.ts.
  • Registration: Added a register.ts file to handle coin registration.
  • Testnet VeChain: Implemented the Tvet class extending Vet with testnet-specific properties.

This pull request ensures the VeChain coins are fully integrated into the BitGo SDK, following the modular architecture and maintaining consistency with existing coin implementations.Ticket: COIN-3934

@mohitkh7 mohitkh7 force-pushed the coin-3934-vechain-skeleton-2 branch 2 times, most recently from efb3ff2 to e1cf311 Compare May 19, 2025 07:35
@mohitkh7 mohitkh7 marked this pull request as ready for review May 19, 2025 09:31
@mohitkh7 mohitkh7 requested review from a team as code owners May 19, 2025 09:31
Copy link
Contributor

@at31416 at31416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

account-lib changes will be taken up later?

@mohitkh7
Copy link
Contributor Author

mohitkh7 commented May 19, 2025

account-lib changes will be taken up later?

Yes, they will be taken up later.

@mohitkh7 mohitkh7 force-pushed the coin-3934-vechain-skeleton-2 branch from e1cf311 to 8ccd9a4 Compare May 19, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants