chore: parallellize keychain and queryPromise #6136
+21
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gautam2305
force-pushed
the
CAAS-7-round-trips
branch
2 times, most recently
from
e0befb2 to
7baae82
Compare
ppongbitgo
reviewed
May 16, 2025
Gautam2305
force-pushed
the
CAAS-7-round-trips
branch
2 times, most recently
from
8ecb7ea to
bbb3faa
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Gautam2305
force-pushed
the
CAAS-7-round-trips
branch
from
c682e7c to
2ba5ea3
Compare
Gautam2305
force-pushed
the
CAAS-7-round-trips
branch
from
87c70b9 to
c829563
Compare
Ticket: CAAS-7
Gautam2305
force-pushed
the
CAAS-7-round-trips
branch
from
4bd8ccb to
037ee71
Compare
margueriteblair
approved these changes
May 20, 2025
ppongbitgo
reviewed
May 20, 2025
| } | ||
| try { | ||
| await ethWallet.sendMany({ ...sendManyParamsCorrectPassPhrase }); | ||
| } catch (e) { | ||
| e.message.should.not.equal(errorMessage); | ||
| e.message.should.equal(errorMessage); |
There was a problem hiding this comment.
why did we change this test?
There was a problem hiding this comment.
After making validation and prebuildQuery parallel, it would give a consistent error message unable to decrypt keychain with the given wallet passphrase. This test explicitly checked for error message to be different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CAAS-7
prebuildAndSignTransactionfunction to improve/sendcoinsendpoint performance