Skip to content

feat: add Apt NFT collection skeleton #6129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

bhavidhingra
Copy link
Contributor

@bhavidhingra bhavidhingra commented May 14, 2025

This pull request introduces support for managing Aptos NFT collections in the SDK. Key changes include adding a new AptNFTCollection class, updating token configuration to include NFT collections, and registering the new functionality in the SDK.

New Feature: Aptos NFT Collection Support

  • Added AptNFTCollection class to manage Aptos NFT collections, including methods for retrieving collection details and creating constructors for NFT collections. (modules/sdk-coin-apt/src/aptNFTCollection.ts)
  • Updated index.ts to export the AptNFTCollection class. (modules/sdk-coin-apt/src/index.ts)
  • Registered Aptos NFT collections in the SDK by adding them to the register function. (modules/sdk-coin-apt/src/register.ts)

Token Configuration Updates

  • Introduced AptNFTCollectionConfig type to define the configuration for Aptos NFT collections. (modules/statics/src/tokenConfig.ts, modules/statics/src/tokenConfig.tsR100-R103)
  • Added nftCollections property to the Tokens interface for Aptos, supporting both Mainnet and Testnet configurations. (modules/statics/src/tokenConfig.ts, [1] [2]
  • Implemented a utility function getFormattedAptNFTCollections to format NFT collection configurations based on the coin map. (modules/statics/src/tokenConfig.ts, modules/statics/src/tokenConfig.tsR628-R642)
  • Updated getFormattedTokens to include formatted NFT collections for both Mainnet and Testnet. (modules/statics/src/tokenConfig.ts, [1] [2]

Export Updates

TICKET: COIN-4036

Copy link
Contributor

@lokesh-bitgo lokesh-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baltiyal baltiyal merged commit e585e04 into master May 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants