Skip to content

feat(sdk-coin-icp): fix memo id validation #6127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
+19 −7
Merged

feat(sdk-coin-icp): fix memo id validation #6127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/sdk-coin-icp/src/lib/transactionBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { BaseAddress, BaseKey, BaseTransactionBuilder, BuildTransactionError, SigningError } from '@bitgo/sdk-core';
import { BaseCoin as CoinConfig } from '@bitgo/statics';
import BigNumber from 'bignumber.js';
import { BaseTransactionBuilder, BuildTransactionError, BaseAddress, SigningError, BaseKey } from '@bitgo/sdk-core';
import { Transaction } from './transaction';
import utils from './utils';
import { DEFAULT_MEMO, IcpTransaction, IcpTransactionData, PayloadsData, Signatures } from './iface';
import { SignedTransactionBuilder } from './signedTransactionBuilder';
import { Transaction } from './transaction';
import utils from './utils';

export abstract class TransactionBuilder extends BaseTransactionBuilder {
protected _transaction: Transaction;
Expand Down Expand Up @@ -58,7 +58,7 @@ export abstract class TransactionBuilder extends BaseTransactionBuilder {
* @returns {TransactionBuilder} This transaction builder
*/
public memo(memo: number): this {
if (memo < 0) {
if (typeof memo !== 'number' || Number.isNaN(memo) || memo < 0) {
throw new BuildTransactionError(`Invalid memo: ${memo}`);
}
this._memo = memo;
Expand Down
18 changes: 15 additions & 3 deletions modules/sdk-coin-icp/test/unit/transactionBuilder/transactionBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { BaseKey, BuildTransactionError } from '@bitgo/sdk-core';
import assert from 'assert';
import should from 'should';
import { getBuilderFactory } from '../getBuilderFactory';
import { BaseKey } from '@bitgo/sdk-core';
import * as testData from '../../resources/icp';
import sinon from 'sinon';
import { DEFAULT_MEMO, MAX_INGRESS_TTL } from '../../../src/lib/iface';
import * as testData from '../../resources/icp';
import { getBuilderFactory } from '../getBuilderFactory';

describe('ICP Transaction Builder', async () => {
const factory = getBuilderFactory('ticp');
Expand Down Expand Up @@ -66,6 +67,17 @@ describe('ICP Transaction Builder', async () => {
await txBuilder.build().should.rejectedWith('sender is required before building');
});

it('should fail to build a txn with incorrect memo', async () => {
const txBuilder = factory.getTransferBuilder();
txBuilder.sender(testData.Accounts.account1.address, testData.Accounts.account1.publicKey);
txBuilder.receiverId(testData.Accounts.account2.address);
txBuilder.amount('10');
const incorrectMemos = ['abcd', undefined];
for (const memo of incorrectMemos) {
assert.throws(() => txBuilder.memo(Number(memo)), BuildTransactionError, `Invalid memo: ${Number(memo)}`);
}
});

it('should fail to build a txn without amount', async () => {
const txBuilder = factory.getTransferBuilder();
txBuilder.sender(testData.Accounts.account1.address, testData.Accounts.account1.publicKey);
Expand Down