feat: add batchStakingBuilder (bond and nominate) and bondExtraBuilder #6126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijit0943
force-pushed
the
SC-1826
branch
3 times, most recently
from
0691236 to
648f74d
Compare
abhijit0943
changed the title
abhijit0943
force-pushed
the
SC-1826
branch
4 times, most recently
from
c78e900 to
19b1b23
Compare
noel-bitgo
reviewed
May 15, 2025
| protected _validators: string[] = []; | ||
|
|
||
| // Batch control | ||
| protected _atomic = true; // Default to batchAll (atomic) |
There was a problem hiding this comment.
We will always set this to true right?
If so we can remove
There was a problem hiding this comment.
Sure, I'll force atomic
Comment on lines
5
to
8
| amount?: string; | ||
| controller?: string; | ||
| payee?: string | { Account: string }; | ||
| validators?: string[]; |
| const calls: string[] = []; | ||
|
|
||
| // Add bond call if amount is set | ||
| if (this._amount) { |
There was a problem hiding this comment.
Amount and validator are always required
There was a problem hiding this comment.
Yes, will implement by forcing atomic
| import { BatchArgs, BondArgs, NominateArgs } from './iface'; | ||
| import BigNumber from 'bignumber.js'; | ||
|
|
||
| export class BatchBuilder extends TransactionBuilder { |
There was a problem hiding this comment.
This will be used for stake and unstake batch?
There was a problem hiding this comment.
We could use another batch builder for unstake, will rename this
…r for polyx TICKET: SC-1826
abhijit0943
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: SC-1826