rust/clippy: disable redundant_clone #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has false positives that can be very subtle, so best to play it safe. async-rs/async-task#23
benma
commented
Jun 19, 2020
| @@ -207,7 +207,7 @@ pub extern "C" fn bitboxbase_state_set_not_alive() { | |||
| #[no_mangle] | |||
| pub extern "C" fn bitboxbase_state_get() -> BitBoxBaseBackgroundState { | |||
| let state = unsafe { &STATE }; | |||
| state.state.clone() | |||
| state.state | |||
There was a problem hiding this comment.
@NickeZ clippy warned this
https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
Sounds legit, do you remember why there was a clone() here?
There was a problem hiding this comment.
Nope, can't remember. Usually I add clone()s as temporary fixes to make the borrowchecker happy. Having many clones is a bit of a code smell.
|
Hm... I'm quite disappointed with clippy at this point. It's always best to leave uncertain things as is and avoid false positives. |
agree, at least the default linters should be 100% false positive free, when it comes to semantics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has false positives that can be very subtle, so best to play it
safe.
async-rs/async-task#23