Improvements to the profile type in chat feature and bug fix for heads in tablist #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ether faction. Improved symbol finding by checking the tab list as well. Added symbol to guild chat As part of checking the tab list, fixed player name stripping issue that prevented heads from being displayed.
barr-israel
requested review from
ILikePlayingGames and
ImRodry
as code owners
ILikePlayingGames
approved these changes
Sep 5, 2022
Collaborator
|
@ImRodry this changes a string key and a string. Is that ok? |
Collaborator
|
I thought these symbols were shown by default and the feature would let you hide them? |
Contributor
Author
|
This feature is to add symbols to chat. |
Collaborator
|
Then call it “Show”, not “Add” |
Contributor
Author
|
changed the string and merged with the recent pr |
ImRodry
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed feature to "Player Symbols" as it also displays the players nether faction.
Improved symbol finding by checking the tab list as well.
Added symbol to guild chat
As part of checking the tab list, fixed player name stripping issue that prevented heads from being displayed.
#621 also tackles the player head bug but it was not merged and this new solution is somewhat cleaner.