Skip to content

Conversation

PhilReedData
Copy link
Collaborator

The https version of the markup generator appears to work but it is broken (reported here: BioSchemas/BioschemasMarkupGenerator#16). Use the http version for now.

The https version of the markup generator appears to work but it is broken (reported here: BioSchemas/BioschemasMarkupGenerator#16). Use the http version for now.
@ljgarcia
Copy link
Collaborator

ljgarcia commented Nov 8, 2024

This generator should be deprecated as it is no longer maintain and it does not use the latest schema.org version.

@ljgarcia
Copy link
Collaborator

@PhilReedData this generator has now been marked as deprecated and the one from DDE has been added. Would you agree to close this PR without further action?

@PhilReedData
Copy link
Collaborator Author

Yes, I can close this PR without action though I have question first. Should we add the DDE schema playground to the menu, replacing the deprecated generator?

@ljgarcia
Copy link
Collaborator

Hi @PhilReedData it makes sense adding DDE schema playground to the menu but as replacement for the generator, we need to make sure that it is link within DDE that corresponds to generation. Could you please update the PR? Thanks

@PhilReedData
Copy link
Collaborator Author

Yes, happy to update this PR to update the menus. Since I know this will conflict with the PR about breadcrumbs, I would like to finish that first, then I'll merge main into this branch and make a cleaner change. I am likely to get lost otherwise.

@PhilReedData
Copy link
Collaborator Author

I've made the menu change in #845 instead, since that is where I made the other menu changes, all in one PR. When that is merged, I will close this PR without any action.

@ljgarcia
Copy link
Collaborator

@PhilReedData you were going to close this PR as covered by another one for the menus. Has it been sorted out?

@PhilReedData
Copy link
Collaborator Author

Well spotted, yes I should have closed this issue. I will do so now, thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants