Occurrence controller record id accommodation #2292
+39
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaSalikov
approved these changes
Mar 12, 2025
| $occurrence = $this->getOccurrence($id); | ||
| if (!$occurrence) { | ||
| return response()->json(['error' => 'Occurrence not found'], 404); | ||
| } | ||
| if($occurrence){ | ||
| if(!$occurrence->occurrenceID) $occurrence->occurrenceID = $occurrence->recordID; | ||
| if($request->input('includeMedia')) $occurrence->media; |
There was a problem hiding this comment.
@Atticus29, Given the current implementation for including inputs, should we prompt that it should be "1" / "not zero" in /documentation?
There was a problem hiding this comment.
@NikitaSalikov what do you mean?
There was a problem hiding this comment.
@Atticus29, I mean adding to description something like this:
1 = Include media
0 or omitted = Do not include media
Or is it too much and should be obvious?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the following in the API Audit doc:
The occurrence/foo endopoints now accommodate occid, occurrenceID, and recordID as identifier inputs.
Pull Request Checklist:
Pre-Approval
masterbranch and PR'd using the merge option (not squashed) into thehotfixbranch.Developmentbranch, NOTmasterPost-Approval
Developmentbranch, remember to use the squash & merge optionhotfixbranch, remember to use the merge option (i.e., no squash).Developmentbranch into the master branch, remember to use the merge optionhotfixbranch into themasterbranch use the squash & merge optionmasterintoDevelopmentshould be made with the merge option (i.e., no squash).hotfixbranch and create a newhotfixbranchhotfixbranch.Developmentbranch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock theDevelopmentbranch to prevent accidental merges while QA takes place. Follow the release protocol here.Thanks for contributing and keeping it clean!