Paleo/ Search Page early/late intervals check and chips functionality #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slight modification to the error text
ljwalker
approved these changes
Feb 28, 2025
…com/BioKIC/Symbiota into search-page-intervals-and-chips-fix
ljwalker
approved these changes
Mar 12, 2025
Atticus29
reviewed
Mar 13, 2025
js/symb/collections.harvestparams.js
Outdated
| let early = frm.earlyInterval.value; | ||
| let late = frm.lateInterval.value; | ||
| if ((early !== "" && late === "") || (early === "" && late !== "")) { | ||
| alert("Both Early Interval and Late Interval need to have a value selected, even if the values are the same."); |
There was a problem hiding this comment.
see collections/search/js/alerts.js for js file implementation.
There was a problem hiding this comment.
@Atticus29 Solved in 28ce6e6
Atticus29
reviewed
Mar 13, 2025
js/symb/collections.harvestparams.js
Outdated
| return false; | ||
| } | ||
| if (early in paleoTimes && late in paleoTimes && paleoTimes[early].myaStart < paleoTimes[late].myaEnd) { | ||
| alert("The Early Interval must be geologically older than the Late Interval."); |
There was a problem hiding this comment.
@Atticus29 Solved in 28ce6e6
Atticus29
requested changes
Mar 13, 2025
…added a float cast to myaStart and myaEnd
@Atticus29 Solved in 28ce6e6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:
@Atticus29 ! I changed the associations data-chips to make the selector elements chip adding/removal uniform. This might break some of your code that I'm unaware of or make some functions redundant (setAssociationTaxonTypeToDefault() and similar are still used though).
Minor:
Pull Request Checklist:
Pre-Approval
masterbranch and PR'd using the merge option (not squashed) into thehotfixbranch.Developmentbranch, NOTmasterPost-Approval
Developmentbranch, remember to use the squash & merge optionhotfixbranch, remember to use the merge option (i.e., no squash).Developmentbranch into the master branch, remember to use the merge optionhotfixbranch into themasterbranch use the squash & merge optionmasterintoDevelopmentshould be made with the merge option (i.e., no squash).hotfixbranch and create a newhotfixbranchhotfixbranch.Developmentbranch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock theDevelopmentbranch to prevent accidental merges while QA takes place. Follow the release protocol here.Thanks for contributing and keeping it clean!