Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling fix for Record Search Form and occurrenceditor tabs #2255

Open
wants to merge 4 commits into
base: Development
Choose a base branch
from

Conversation

NikitaSalikov
Copy link
Collaborator

Before:

Screenshot 2025-02-21 at 12 41 21 PM

After:

Screenshot 2025-02-21 at 12 52 55 PM

Changes Made:

  • added button and icon-button classes to buttons in the tabs and record search form
  • increased font-size in record search form
  • added danger-button class
  • added a custom :disabled class
  • added background color change on hover

Pull Request Checklist:

Pre-Approval

  • There is a description section in the pull request that details what the proposed changes do. It can be very brief if need be, but it ought to exist.
  • Hotfixes should be branched off of the master branch and PR'd using the merge option (not squashed) into the hotfix branch.
  • Features and backlog bugs should be merged into the Development branch, NOT master
  • All new text is preferably internationalized (i.e., no end-user-visible text is hard-coded on the PHP pages), and the spreadsheet tracking internationalizations has been updated either with a new row or with checkmarks to existing rows.
  • There are no linter errors
  • New features have responsive design (i.e., look aesthetically pleasing both full screen and with small or mobile screens)
  • Symbiota coding standards have been followed
  • If any files have been reformatted (e.g., by an autoformatter), the reformat is its own, separate commit in the PR
  • Comment which GitHub issue(s), if any does this PR address:
    [3.2] Record Search Form looks different from Editor View vs. Table View #2248
  • If this PR makes any changes that would require additional configuration of any Symbiota portals outside of the files tracked in this repository, make sure that those changes are detailed in this document.

Post-Approval

  • It is the code author's responsibility to merge their own pull request after it has been approved
  • If this PR represents a merge into the Development branch, remember to use the squash & merge option
  • If this PR represents a merge into the hotfix branch, remember to use the merge option (i.e., no squash).
  • If this PR represents a merge from the Development branch into the master branch, remember to use the merge option
  • If this PR represents a merge from the hotfix branch into the master branch use the squash & merge option
    • a subsequent PR from master into Development should be made with the merge option (i.e., no squash).
    • Immediately delete the hotfix branch and create a new hotfix branch
    • increment the Symbiota version number in the symbase.php file and commit to the hotfix branch.
  • If the dev team has agreed that this PR represents the last PR going into the Development branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock the Development branch to prevent accidental merges while QA takes place. Follow the release protocol here.
  • Don't forget to delete your feature branch upon merge. Ignore this step as required.

Thanks for contributing and keeping it clean!

@themerekat
Copy link
Collaborator

There are still some old buttons!
image

Media tab:
image

Linked Resources tab
image

Copy link
Collaborator

@themerekat themerekat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment

Copy link
Collaborator

@themerekat themerekat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing a slight difference in the fonts and sizes of the buttons. Here's occurrencetabledisplay
image

and here's occurrenceditor
image

See how the font is different? Maybe something to do with the head? I know we didn't want to include the same head for occurrenceeditor for some reason, but I don't know if there's a different way around this.

@NikitaSalikov NikitaSalikov requested a review from egbot February 21, 2025 23:40
@NikitaSalikov
Copy link
Collaborator Author

@egbot , could you remind me what is the status of occurrenceeditor page? It needs a major refactoring, and you were working on it at some point, so I am not sure if I should make big changes before yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants