[3.3+] /api/v2/exsiccata/{identifier}/number endpoint #2245
Conversation
* added the endpoint exsiccata/identifier * indentation fix * remove redundant casting * add quotes to HTML response codes * fix bug where we accidentally removed the array type cast. Sorry, Nikita! -Mark * make removal of lasteditedby more efficient --------- Co-authored-by: Nikita Salikov <[email protected]>
There was a problem hiding this comment.
@Atticus29 Tested and it works! But why the title is ".../number/{numberIdentifier}" if this is /number endpoint?
Atticus29
changed the title
Good call. Yeah, I don't know where those wires got crossed in my brain. Fixed now. Thanks! |
| return response()->json(['error' => 'Record not found'], 404); | ||
| } | ||
|
|
||
| unset($record->lasteditedby); |
There was a problem hiding this comment.
I don't think this is needed since that field is set to be hidden within the model
There was a problem hiding this comment.
Fixed in 8061494. That problem was that the QueryBuilder doesn't respect the hidden array. But switching to stricter eloquent (h/t chatGTP) solved the problem.
| * required=false, | ||
| * @OA\Schema(type="integer", default=0) | ||
| * ), | ||
| * @OA\Parameter( |
There was a problem hiding this comment.
Within the other endpoint I've listed the required input variables first, with the standard limit and offset variable listed last after all the other input variable. Small issue, but might as well be consistent.
There was a problem hiding this comment.
Fixed in 60830e7.
Description
This PR adds the /api/v2/exsiccata/{identifier}/number endpoint to the API and docs.
Not to be merged in immediately
This PR creates the API-updates branch, into which future PRs for the API changes can be made.
Pull Request Checklist:
Pre-Approval
masterbranch and PR'd using the merge option (not squashed) into thehotfixbranch.Developmentbranch, NOTmasterPost-Approval
Developmentbranch, remember to use the squash & merge optionhotfixbranch, remember to use the merge option (i.e., no squash).Developmentbranch into the master branch, remember to use the merge optionhotfixbranch into themasterbranch use the squash & merge optionmasterintoDevelopmentshould be made with the merge option (i.e., no squash).hotfixbranch and create a newhotfixbranchhotfixbranch.Developmentbranch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock theDevelopmentbranch to prevent accidental merges while QA takes place. Follow the release protocol here.Thanks for contributing and keeping it clean!