-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paleo fields to the Data Editor Search Form #1900
base: paleo-test
Are you sure you want to change the base?
Conversation
This seems like a good suggestion to me. |
Original notes from discussions between SSH dev+Lindsay:
Responses to questions posed above from GEO OSE/paleo PI team (from 2024-12-12):
(Note that this feedback is specific to the Data Editor Search Form/not related to the Public Search form.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Taxon Environment missing from dropdown
- Change "Remarks" to "Stratigraphic Remarks" for clarity
Changes Made:
Batch Update Issue:
@egbot , as we previously discussed, there's an issue with omoccurredits table (OccurrenceEditorManager starting line ~2007):
omoccurredits table doesn't have paleo fields columns. Should we add them to the table?
Currently the code is skipping the INSERT INTO omoccurredits table if Paleo fields are present. Not the final solution, just for testing.
Pull Request Checklist:
Pre-Approval
master
branch and PR'd using the merge option (not squashed) into thehotfix
branch.Development
branch, NOTmaster
https://github.com/orgs/BioKIC/projects/6/views/28?visibleFields=%5B37887625%2C%22Title%22%2C%22Assignees%22%2C37442248%2C69347678%2C%22Status%22%5D&sortedBy%5Bdirection%5D=&sortedBy%5BcolumnId%5D=&pane=issue&itemId=79647516
Post-Approval
Development
branch, remember to use the squash & merge optionhotfix
branch, remember to use the merge option (i.e., no squash).Development
branch into the master branch, remember to use the merge optionhotfix
branch into themaster
branch use the squash & merge optionmaster
intoDevelopment
should be made with the merge option (i.e., no squash).hotfix
branch and create a newhotfix
branchhotfix
branch.Development
branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock theDevelopment
branch to prevent accidental merges while QA takes place. Follow the release protocol here.Thanks for contributing and keeping it clean!