Skip to content

fix(auth): check hasattr before accessing request.session Fixes #16035 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bharath420 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(auth): check hasattr before accessing request.session Fixes #16035 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/google-auth/google/auth/compute_engine/_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,9 @@ def _prepare_request_for_mds(request, use_mtls=False) -> None:

"""
# Only modify the request if mTLS is enabled, and request supports sessions.
if use_mtls and hasattr(request, "session"):
if use_mtls:
# Ensure the request has a session to mount the adapter to.
if not request.session:
if not hasattr(request, "session") or not request.session:
request.session = requests.Session()

adapter = _mtls.MdsMtlsAdapter()
Expand Down