Don't add "accounts/fireworks/models" prefix for Fireworks Provider #15938
Conversation
|
@1stprinciple is attempting to deploy a commit to the CLERKIEAI Team on Vercel. A member of the Team first needs to authorize it. |
|
|
1stprinciple
changed the title
| ) -> dict: | ||
| prompt = _transform_prompt(messages=messages) | ||
|
|
||
| if not model.startswith("accounts/"): |
There was a problem hiding this comment.
Hi @1stprinciple can you share an example of this not working for text completions?
There was a problem hiding this comment.
For example, we now support fireworks model format that looks like
fireworks/<model_id>#fireworks/<deployment_id> that doesn't start with "accounts"
There was a problem hiding this comment.
note: we're considering removing this "short" form syntax in the future to simplify the number of ID formats we support.
let's discuss internally
There was a problem hiding this comment.
@1stprinciple removing this would cause failing requests for models that do require it, and users who were expecting litellm to handle this (as documented).
Can you suggest a change which accounts for your model id #fireworks change without failing requests for existing user code?
4 participants
Models served on fireworks.ai don't necessarily start with "account"