ANW-2966 build: Allow overriding test DB host/port - #2
Open
awilfox wants to merge 1 commit into
Open
Conversation
This change allows the environment to override the host and port used for connecting to the test database. The defaults are set to the values originally used, so there should be no functional change for those who do not explicitly set the environment variables. Also adds an option to skip TLS certificate verification for the test database load only. Since this is a write operation for test fixtures only (no sensitive data is used, and no data is read nor trusted), this should not be a security risk.
Member
Author
|
Since I can't find an upstream reference for the merge request they mentioned in the Jira ticket, I opened this so that we can show the ArchivesSpace team what I worked on if they need it. |
|
This looks good but do we want to wait and see what changes were made with ANW-2966 first? |
Member
Author
|
Yeah, this is mostly so that we have something to show them if we need to. Like I said, while their tracker says "request opened" I don't see it on the public repo so I don't know what they are actually fixing. It could be the GeckoDriver version update, it could be this build stuff, it could be both, or even neither if they are just wanting to update the |
davezuckerman
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket (JIRA or GitHub Issue)
[ANW-2966]
Summary
Running
db:load:testordb:dump:testused a hardcoded localhost database server.This caused issues running the database tasks in Docker as part of the test build.
Therefore, this change allows users to override the host/port of the test database using environment variables.
Types of changes
Checklist:
The test suite could not run before in Docker, and can now, so that itself is a test.