Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): cleanup lodash imports and add it as peer #134

Merged
merged 1 commit into from
Nov 28, 2023
Merged

chore(deps): cleanup lodash imports and add it as peer #134

merged 1 commit into from
Nov 28, 2023

Conversation

yfrommelt
Copy link
Contributor

@yfrommelt yfrommelt commented Nov 23, 2023 •
edited
Loading

Remove old and deprecated configuration of webpack for lodash tree shaking.
Just import the used function from lodash to prevent it to being fully loaded in projects.
Move lodash import to package's peer dependencies to allow different version in projects.

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 6970486304

  • 15 of 15 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 94.737%
Totals Coverage Status
Change from base Build 4989717649: -0.1%
Covered Lines: 192
Relevant Lines: 198
💛 - Coveralls

@yfrommelt yfrommelt marked this pull request as ready for review November 23, 2023 13:48
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 6970899734

  • 15 of 15 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 94.969%
Totals Coverage Status
Change from base Build 4989717649: 0.1%
Covered Lines: 188
Relevant Lines: 193
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7005312465

  • 15 of 15 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.737%
Totals Coverage Status
Change from base Build 7003521903: 0.0%
Covered Lines: 192
Relevant Lines: 198
💛 - Coveralls

@yfrommelt yfrommelt requested a review from flepretre November 27, 2023 09:19
flepretre
flepretre reviewed Nov 27, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@yfrommelt yfrommelt requested a review from flepretre November 27, 2023 09:37
@yfrommelt yfrommelt force-pushed the cleanup-lodash-imports branch from a38dae3 to aa88a05 Compare November 27, 2023 10:54
@yfrommelt yfrommelt force-pushed the cleanup-lodash-imports branch from aa88a05 to 9f95897 Compare November 27, 2023 12:57
@yfrommelt yfrommelt merged commit fb1acb7 into master Nov 28, 2023
4 checks passed
@yfrommelt yfrommelt mentioned this pull request Nov 28, 2023
Merged
@yfrommelt yfrommelt mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpoissonnet jpoissonnet jpoissonnet approved these changes

@EtienneDOYON EtienneDOYON EtienneDOYON approved these changes

@flepretre flepretre flepretre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yfrommelt @flepretre @EtienneDOYON @jpoissonnet