Fix draft page creation bug (#333)

* Fix draft page creation bug * update test * fix test
BeaconCMS · Jan 15, 2025 · d6885ed · d6885ed
1 parent 1f5c0b8
commit d6885ed
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/beacon/live_admin/live/page_editor_live/form_component.ex b/lib/beacon/live_admin/live/page_editor_live/form_component.ex
@@ -176,7 +176,7 @@ defmodule Beacon.LiveAdmin.PageEditorLive.FormComponent do
        |> assign(page: page, show_modal: nil)
        |> update(:page_status, &if(user_action == "publish", do: :published, else: &1))
        |> put_flash(:info, "Page #{String.trim_trailing(user_action, "e")}ed successfully")
-       |> push_patch(to: beacon_live_admin_path(socket, site, "/pages/#{page.id}"))}
+       |> push_navigate(to: beacon_live_admin_path(socket, site, "/pages/#{page.id}"))}
     else
       {:error, changeset} ->
         changeset = Map.put(changeset, :action, :save)

diff --git a/test/beacon/live_admin/live/page_editor_live/new_test.exs b/test/beacon/live_admin/live/page_editor_live/new_test.exs
@@ -20,10 +20,10 @@ defmodule Beacon.LiveAdmin.PageEditorLive.NewTest do
     |> form("#page-form", page: %{path: "/my/page", title: "My Page", format: "heex"})
     |> render_submit(%{page: %{"template" => "<div>test</div>"}, save: "save"})
 
-    assert_patch(live)
-    assert has_element?(live, "#flash", "Page saved successfully")
-    assert has_element?(live, "h1", "Edit Page")
-    assert has_element?(live, "button", "Save Changes")
+    {path, flash} = assert_redirect(live)
+
+    assert path =~ ~r"^/admin/site_a/pages/[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$"
+    assert flash["info"] == "Page saved successfully"
   end
 
   describe "extra page fields" do