fix: deprecation warnings #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Luckily I came here before creating a PR myself. I'd also love to hear if the repo is still maintained. |
|
Is there any reason not to merge this? I came across the issue ($post_id being null on a 404 page) and wanted to fix it. It's been nearly a year 🤔 @herewithme |
Author
|
Great catch! I total forgot about this PR. Let's try to also ping @MaximeCulea as he seems to be the top contributor 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@herewithme, is this repo still maintained? Just wondering since there are some open PRs and issues which haven't been touched in a while. Asking to know if I need to patch this deprecation warnings on my own codebase for now. Thanks for the good work!