Skip to content

Adds debugLabel for the image stream completer #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Adds debugLabel for the image stream completer #984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
523c1ce
Update multi_image_stream_completer.dart
AlexV525 Nov 3, 2024
87624c0
Update cached_network_image_provider.dart
AlexV525 Nov 3, 2024
2ad9deb
Update multi_image_stream_completer.dart
AlexV525 Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cached_network_image/lib/src/image_provider/cached_network_image_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ class CachedNetworkImageProvider
codec: _loadBufferAsync(key, chunkEvents, decode),
chunkEvents: chunkEvents.stream,
scale: key.scale,
debugLabel: key.url,
informationCollector: () => <DiagnosticsNode>[
DiagnosticsProperty<ImageProvider>('Image provider', this),
DiagnosticsProperty<CachedNetworkImageProvider>('Image key', key),
Expand Down Expand Up @@ -132,6 +133,7 @@ class CachedNetworkImageProvider
codec: _loadImageAsync(key, chunkEvents, decode),
chunkEvents: chunkEvents.stream,
scale: key.scale,
debugLabel: key.url,
informationCollector: () => <DiagnosticsNode>[
DiagnosticsProperty<ImageProvider>('Image provider', this),
DiagnosticsProperty<CachedNetworkImageProvider>('Image key', key),
Expand Down
18 changes: 16 additions & 2 deletions cached_network_image/lib/src/image_provider/multi_image_stream_completer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@ class MultiImageStreamCompleter extends ImageStreamCompleter {
MultiImageStreamCompleter({
required Stream<ui.Codec> codec,
required double scale,
String? debugLabel,
Stream<ImageChunkEvent>? chunkEvents,
InformationCollector? informationCollector,
}) : _informationCollector = informationCollector,
_scale = scale {
this.debugLabel = debugLabel;
codec.listen(
(event) {
if (_timer != null) {
Expand Down Expand Up @@ -101,7 +103,13 @@ class MultiImageStreamCompleter extends ImageStreamCompleter {
_frameCallbackScheduled = false;
if (!hasListeners) return;
if (_isFirstFrame() || _hasFrameDurationPassed(timestamp)) {
_emitFrame(ImageInfo(image: _nextFrame!.image, scale: _scale));
_emitFrame(
ImageInfo(
image: _nextFrame!.image,
scale: _scale,
debugLabel: debugLabel,
),
);
_shownTimestamp = timestamp;
_frameDuration = _nextFrame!.duration;
_nextFrame = null;
Expand Down Expand Up @@ -151,7 +159,13 @@ class MultiImageStreamCompleter extends ImageStreamCompleter {

// This is not an animated image, just return it and don't schedule more
// frames.
_emitFrame(ImageInfo(image: _nextFrame!.image, scale: _scale));
_emitFrame(
ImageInfo(
image: _nextFrame!.image,
scale: _scale,
debugLabel: debugLabel,
),
);
return;
}
_scheduleAppFrame();
Expand Down