-
-
Notifications
You must be signed in to change notification settings - Fork 77
feat!: renamed package geocoding_ios
to geocoding_darwin
#245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
OutdatedGuy
wants to merge
7
commits into
Baseflow:main
Choose a base branch
from
OutdatedGuy:refactor/rename-ios-to-darwin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat!: renamed package geocoding_ios
to geocoding_darwin
#245
OutdatedGuy
wants to merge
7
commits into
Baseflow:main
from
OutdatedGuy:refactor/rename-ios-to-darwin
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mvanbeusekom @JeroenWeener can you guys review this PR? |
512f153
to
5b94e80
Compare
@OutdatedGuy can you do a rebase on this PR? |
94239b0
to
9672221
Compare
@martijn00 Done ✅ |
9672221
to
bfa7463
Compare
@martijn00 @mvanbeusekom @JeroenWeener any idea when this PR will be reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
geocoding_ios
togeocoding_darwin
to later add macOS support. Will follow up with macOS support PR after this is merged.resolves #244
Pre-launch Checklist
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.CHANGELOG.md
to add a description of the change.///
).main
.dart format .
and committed any changes.flutter analyze
and fixed any errors.