add opt. sensor_model expected_rate and per_second #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional parameters to the sensor_model, expected_rate, hit_per_second and miss_per_second. If the expected_rate is set, it is used when calculating the probability of a single hit or miss from the new hit_per_second and miss_per_second parameters. This makes it easier to parameterize by time and then to simply set the expected sensor update rate. Add a throttled warning if the sensor is not updating near the expected rate.
howardcochran
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @bobhenz-jabil)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional parameters to the sensor_model, expected_rate, hit_per_second and miss_per_second. If the expected_rate is set, it is used when calculating the probability of a single hit or miss from the new hit_per_second and miss_per_second parameters. This makes it easier to parameterize by time and then to simply set the expected sensor update rate. Add a throttled warning if the sensor is not updating near the expected rate.
This change is