Update Spring

[csikb]

No description provided.

[coderabbitai]

Walkthrough

This update modifies the dependency management configuration by updating the Spring Cloud dependencies BOM version in the Gradle build script. Additionally, a test in the label repository module is updated to use a different set of label entities, including the introduction of a new constant for testing purposes. The test logic remains consistent, focusing on verifying label retrieval by name.

Changes

File(s)	Change Summary
buildSrc/src/main/kotlin/dependency-management.gradle.kts	Updated Spring Cloud dependencies BOM version from "2023.0.5" to "2024.0.1" in the enforced platform.
server/data/src/test/.../LabelEntityRepositoryTest.kt	Modified test to use LABEL_1 and new LABEL_2 entity; added LABEL_2 constant in companion object.

Possibly related PRs

• Update gradle config #331: Both PRs modify the dependency management configuration in the same Gradle Kotlin script file, specifically updating how Spring Cloud BOM dependencies are declared and managed.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c01b16 and 5c849bb.

⛔ Files ignored due to path filters (1)

• gradle/libs.versions.toml is excluded by !**/*.toml

📒 Files selected for processing (2)

• buildSrc/src/main/kotlin/dependency-management.gradle.kts (1 hunks)
• server/data/src/test/kotlin/hu/bsstudio/bssweb/label/repository/LabelEntityRepositoryTest.kt (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: integration
• GitHub Check: build
• GitHub Check: test

🔇 Additional comments (3)

buildSrc/src/main/kotlin/dependency-management.gradle.kts (1)

12-12:

❓ Verification inconclusive

Spring Cloud dependencies version upgraded

The upgrade from "2023.0.5" to "2024.0.1" represents a significant version jump, moving to a new major version of Spring Cloud. This update likely includes new features, bug fixes, and potentially breaking changes.

---

🏁 Script executed:

#!/bin/bash
# Let's check for any changelog information to understand the impact of this upgrade

echo "Searching for Spring Boot version that might be compatible with this Spring Cloud version..."
grep -r "org.springframework.boot" --include="*.gradle*" --include="*.kt" --include="*.java" . | grep -v "/build/" | grep "version"

echo "Looking for Spring Cloud related imports to understand usage patterns..."
grep -r "org.springframework.cloud" --include="*.java" --include="*.kt" . | grep -v "/build/" | head -n 20

Length of output: 1921

---

🏁 Script executed:

#!/bin/bash
# Fetch the Spring Cloud BOM POM to determine the managed Spring Boot version
curl -s "https://repo1.maven.org/maven2/org/springframework/cloud/spring-cloud-dependencies/2024.0.1/spring-cloud-dependencies-2024.0.1.pom" \
  | grep -A1 "<spring-boot.version>"

Length of output: 175

---

Verify Spring Boot alignment after Spring Cloud 2024.0.1 upgrade

The bump from Spring Cloud 2023.0.5 to 2024.0.1 pulls in a new major Spring Cloud release that manages a specific Spring Boot version. Before merging:

• Manually confirm the spring-boot.version property in the 2024.0.1 BOM POM.
• Align your project’s Spring Boot dependencies to that managed version.
• Run integration tests against your OpenFeign clients and any other Spring Cloud features (e.g. in client/…/config/*.kt and server/client/…/config/*.kt).

buildSrc/src/main/kotlin/dependency-management.gradle.kts:

- api(enforcedPlatform("org.springframework.cloud:spring-cloud-dependencies:2023.0.5"))
+ api(enforcedPlatform("org.springframework.cloud:spring-cloud-dependencies:2024.0.1"))

server/data/src/test/kotlin/hu/bsstudio/bssweb/label/repository/LabelEntityRepositoryTest.kt (2)

30-30: Test enhancement with additional test data

The test has been improved by using multiple label entities (LABEL_1 and LABEL_2) instead of just one. This provides better coverage for the repository's findAllByNameIn method by testing it with multiple items and a non-existent label name.

Also applies to: 33-33, 40-40

---

30-35:

✅ Verification successful

Verify repository method implementation

The test verifies that findAllByNameIn correctly returns only the entities with matching names and ignores non-existent names. While the test looks correct, it's good practice to ensure the repository interface properly handles this filtering.

---

🏁 Script executed:

#!/bin/bash
# Let's check how the findAllByNameIn method is defined in the repository interface

echo "Checking the LabelRepository interface definition:"
cat "$(find server -name "LabelRepository.kt" -type f)"

echo "Checking for any custom implementation of findAllByNameIn:"
grep -r "findAllByNameIn" --include="*.kt" --include="*.java" server | grep -v "LabelEntityRepositoryTest.kt"

Length of output: 1511

---

Repository method is correctly defined

Confirmed that findAllByNameIn is declared in
server/data/src/main/kotlin/hu/bsstudio/bssweb/label/repository/LabelRepository.kt
and there is no custom implementation elsewhere. Spring Data JPA will generate the query based on the method name, so the test accurately verifies the filtering behavior. No further changes are needed.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud