-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Contentful objects #37
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/blacksocialists/world-of-jackson/a808580js |
This is great, thanks Imogen! One thing I noticed with the Demo page is that the JSON seems to have a lot of duplicate objects (e.g. every child object also contains the full JSON for the parent object containing it.) Is there a way we can reduce that duplication to save on bandwidth and RAM? Maybe one way is to only include an id pointing to the parent object instead of the entire parent object? |
I realize now that the JSON is only representing the in memory objects, which I assume have references to the parent objects instead of duplicate objects. That seems fine to me if that's the case; please ignore my earlier comment. |
📝Changed routes:
Commit 75612e6 (https://world-of-jackson-git-feature-contentful-utils.blacksocialists.now.sh). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retroactively approved XD
Demo page
ContentfulObject
class abstracting away Contentful boilerplateyarn contentful-typescript-codegen
ContentfulObject
instances for each class in our data modelCloses #9
Issues resulting from this PR:
ContentfulObject
'sfindRelated
step #36 Include non-cyclical fields inContentfulObject
'sfindRelated
step (help wanted)