Skip to content

PEM2-25-fix-simulation-ethiopian-calendar#330

Merged
mestachs merged 3 commits into
masterfrom
PEM2-25-fix-simulation-ethiopian-calendar
Sep 4, 2025
Merged

PEM2-25-fix-simulation-ethiopian-calendar#330
mestachs merged 3 commits into
masterfrom
PEM2-25-fix-simulation-ethiopian-calendar

Conversation

@mestachs
Copy link
Copy Markdown
Collaborator

@mestachs mestachs commented Sep 4, 2025

Self proof reading checklist

  • Did I run Pronto and fixed all warnings (pronto run -c origin/dev)
  • Make sure all naming and code will remain understandable in 6 month by someone new to the project or by you.
  • Did I test the right thing?
  • Did I test corner cases, non happy path (defensive testing)?
  • Check that I used the ad-hoc patterns and created files accordingly (Presenters, Services, Search object, Form object,...)
  • Check code efficiency with record intensive project
  • Update documentation,readme accordingly

Thanks!

@mestachs mestachs merged commit 75b4d84 into master Sep 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant