Open
Conversation
b4dc2f9 to
ab8de09
Compare
… called and in the script updateDBRecords.py the functions like updatePositionsRecords which orignally exist in departmentpositions are called to a different file called userInsertFuncitons.py so it just moving functions to a correct file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: #533
Issue Description: Now that we have an update script that runs frequently, we don't need to check the external tracy database during regular application usage. We should remove the dependency and just use the data that we have locally.
There should be a sanity check, though, to make sure there aren't valid reasons to be checking with Tracy outside of the update script.
Tracy Codes Changed:
Tracy Codes Not Changed:
TestCase added for (These test are created because getting position have complex peewee in it):
Codes changed:
All of the code changed are through replacing Tracy functions and Tracy calls with Peewee calls
UI Testing:
Go to the sidebar > New Labor Status Form > Select either Supervisor, Department, Terms and Students (You might need to create a term in administration> manage terms to create LSF form)
Go to the sidebar > New Labor Status Form > Create a labor Status Form > Add Student > Review > A modal pop up > Click Submit (You might need to create a term in administration> manage terms to create LSF form)