Skip to content

Conversation

RueHaile
Copy link
Contributor

@RueHaile RueHaile commented Jul 3, 2025

Resolved issue: 451_ LSF

Fixed:

  • The log out button on LSF student side has been fixed so that they will be logged out successfully and also communicated about it by removing the remove error message and showing a shibboleth logged out message on a new web page.

Issue:

-Logout page doesn’t log you out and only redirects to basic HTML template (On student side).

  • It gave a maximum recursion depth reached error, on the side of development and an unexpected error occurred on the production side when the user attempts to log out.
    -The user was not informed that they have successfully checked out only that there has been:
    “Unexpected error has occurred, an administrator has been notified and sorry for the problem page”.

Testing the issue :Development error
image

Testing the issue: production/published side
image

Currently tested to output/ resolved :
image

When the user is logged out, they are redirected to the Duo login page:-
image
If the user presses back on the web browser, a stale request will be rendered.
image

Test:
• Normally, students the way that we can get the labor form website if we are provided with a link from a supervisor.
• Check out branch: logout_issue_45.
• Once on the page, there is a sidebar with a logout button on it.
• Click the log out and followed by a “logged-out operation is complete page.
• The user has successfully logged out; they can exit the page.

RueHaile added 2 commits June 30, 2025 13:37
…rogram. It is still not fixed we need to find a better landing page. it is a work in progress.
… Shibboleth logged out page is renderd.

-The logout issue on the student side has been resolve from rendering an infinite cycle error to a Shibboleth logged out page.
@bakobagassas
Copy link

Everything looks fine

@adjagbodjouf
Copy link

adjagbodjouf commented Jul 3, 2025

After logging out, the successful logout page loads, indicating that the user has been logged out. But after this page shows up, you can click the back arrow everything still works fine, like the user still hasn't logged out. Even after refreshing, everything appears to still be working when it shouldn't. This may just be because this is all running locally, but if not, then it may be something you need to fix.

Responses:

  • The back arrow won't be rendering the web page anymore without the user logging in.
  • The back button will not work when they are logged out.
    This issue has been resolved.

@adjagbodjouf
Copy link

This would look better centered on the page instead of being left all the way at the top.

image

The text might also look better centered in the box.

-The redirect to the logout in the main route is added.
-In the HTML, prevent back is added in order to remove the history and as a result prevent the back button from working.
@RueHaile
Copy link
Contributor Author

RueHaile commented Jul 8, 2025

This would look better centered on the page instead of being left all the way at the top.

image

The text might also look better centered in the box.

Response:

  • This is no longer an issue because we are rendering a different page.
    This issue has been resolved.

@BesherKitaz
Copy link
Contributor

BesherKitaz commented Jul 11, 2025

I got this error when trying to open the site on the test database when I try to open the website as a student (I set the user to 'kitazb' in secret_config.yaml, which is a student username):

image

When I set the username back to "heggens" to view the supervisor portal:

image

And then when I clicked "back," it took me to my profile in lsf production site:

image

RESPONSE:
Clearing the cache should resolve the issue.

Copy link
Contributor

@BrianRamsay BrianRamsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the recursion error, but doesn't actually log them out. We need to figure out what we need to configure so that going to https://secure.berea.edu/Shibboleth.sso/Logout actually ends their duo/shibboleth session.

If we can't figure that part out, we should just remove the Logout link altogether.

@BrianRamsay
Copy link
Contributor

I implemented just the logout fix in commit 5d2fca2. Had to find the right url redirect and make a config change in /etc/shibboleth/shibboleth2.xml in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants