Removed labor meetings from participation history#1685
Open
Karina-Agliullova wants to merge 2 commits intodevelopmentfrom
Open
Removed labor meetings from participation history#1685Karina-Agliullova wants to merge 2 commits intodevelopmentfrom
Karina-Agliullova wants to merge 2 commits intodevelopmentfrom
Conversation
MImran2002
approved these changes
Feb 27, 2026
Contributor
MImran2002
left a comment
There was a problem hiding this comment.
I don't think I have any changes in mind, this is a quick fix and I have talked to Karina that a long-term fixed would possibly be an attribute but for now I think it is a great fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1683
There was a request to remove labor meeting events from the Participation history. And also, those labor meetings should be tracked in reports for each academic year per each term. The problem with removing it from participation history was inconsistency in naming of labor meetings and also filtering: sometimes they are named "CELTS labor meeting" or "Labor meeting(date)", so it was confusing to remove Labor only events as there are trainings that are also filtered the exact same way.
Changes
Testing