Skip to content

Paging issue#1675

Open
bakobagassas wants to merge 16 commits intodevelopmentfrom
pagingIssue
Open

Paging issue#1675
bakobagassas wants to merge 16 commits intodevelopmentfrom
pagingIssue

Conversation

@bakobagassas
Copy link
Contributor

@bakobagassas bakobagassas commented Feb 16, 2026

Paging issue

Fixes #1656

  • Arrange the flow of the list in volunteer details when RSVP is unchecked. Here, for instance, Joyce's details appear on the third page, as she is the only person listed. So logically, she should be appearing on the first page. Which means whenever these checkmarks are done the page should reconsolidate the data and repopulate them to fit the filter that is there like 50-100.

Changes

  • Changed mainly the JavaScript file
  • Now we are not anymore manually hiding table rows when checkboxes were unchecked but we use the DataTables custom filtering
  • Removed Duplicate DataTable Initialization

Now joyce appears on the first page when RSVP unchecked
image

Testing

  • Go to events page
  • Change to the fall 2025 term
  • go to Bonner Scholars tab
  • Click on the only event there
  • Click on volunteer details
  • You can check and uncheck the RSVP box

@github-actions
Copy link

View Code Coverage

{% if username not in seen %}
{% set _ = seen.append(username) %}
{% if p in attended %}
{{ createTable(p, 'attended') if type == 'table' else createCard(p, 'attended') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of using create table 3 times, create a new variable called 'status', for example, and set that variable to be 'attended', 'rsvp', and 'waitlist within the if statements. Then after the if statements create the table, ex:

{% set status = None %}
{% if p in attended %}
    {% set status = 'attended' %}
{% elif p in rsvp %}
    {% set status = 'rsvp' %}
{% elif p in waitlist%}
    {% set status = 'waitlist' %}
{% endif %}

{% if status %}
    {{ createTable(p, status) if type == 'table' else createCard(p, status) }}
{% endif %}

This would make general code maintenance in the future easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistencies in Volunteer Details table

3 participants