Bonner checkmark profile

[MImran2002]

Bonner requirements checkmarks on the profile page

Fixes #1370

• The checkmarks for Bonner requirements on the profile page should respect the frequency of the requirement. Something that is required once, would have one checkmark or X. Something that is required twice should have two icons, every term should show a checkmark for each term and an x for each term missed. As part of this we should add a ‘Twice’ frequency.

Changes

• Add options for both term and twice in Bonner Management under Brian as admin.
• Reproduce the certification requirement with ticks if they have done and cross if they haven't

Testing

Navigating to the branch

• Use git checkout bonnerCheckmarkProfile
• Pull the code with git pull
• Reset the database with to test and run tests/run_tests.sh
• Run the application with flask run
• Navigate to the navigate bar and click on admin drop down feature
• Click Bonner_Management and go to Requirements and click on the "Add Requirement" button then name it and choose every term as the Frequency

#Creating and checking the certification

• Go to Create Event and Select Bonner Scholars to create certification events
• Create an Event and make sure you choose the Bonner Requirement that you added a while ago.
• Select the invite cohorts that has Zach Neill.
• And click Create Event
• Go to manage volunteers where the RSVP and Waitlist checked Zach Neill as attended and saved
• Then go to the side bar and navigate to Zach Neill as a user
• Go to My Profile and click the Bonner Program dropdown
• You will see the tick if you have finished and a number of cross on the terms you have not
• Hover over the requirement that you created and will see the tooltips

[WackyWeaver]

There is a html logic issue on the tool tip when there have been no attended terms. Also, the tooltip never shifts when there are fewer terms available for underclassmen.

[WackyWeaver]

LTGM! Please add a comment for the formula in missedTerms and rename certs

[github-actions]

View Code Coverage

[WackyWeaver]

I appreciate the comments added to the calculating logic section. A little long compared to a lot in the rest of the code base, but everything else LGTM!

[bakobagassas]

When I follow the steps in the PR, everything works up to where I click to save the event. It is failing to save the event.

[bakobagassas]

Also, I have noticed that when I try to create an event, before even selecting the requirement that had "all term", I am unable to select a term in the event itself.

[bakobagassas]

Also, something seems to be breaking. When I try to access event lists (where we see the event we created), the page is not accessible on your branch; it gives an error page. nb: I already reset the database multiple times.

[MImran2002]

Also, something seems to be breaking. When I try to access event lists (where we see the event we created), the page is not accessible on your branch; it gives an error page. nb: I already reset the database multiple times.

There are tests breaking in development:
tests/code/test_serviceLearningCourses.py ...F......
tests/code/test_spreadsheet.py F..FFFFFFFFFFF
tests/code/test_term.py ...
tests/code/test_transcripts.py .F..

And for the event I am able to select the term:

and I am able to see an event list :

I can definitely guide you with the set up when might you be free on Wednesday or Thursday.

[bakobagassas]

I wonder why it is only showing 3 checkmarks. Wasn't it supposed to be every term (so 8 terms)?

[MImran2002]

I wonder why it is only showing 3 checkmarks. Wasn't it supposed to be every term (so 8 terms)?

Hello Sara, Thank you for the question. That's what I thought as well but after reading through the issues and code I remember why. These are the few questions you might potentially have reviewing this issue.

Why am I seeing only three checkmarks, shouldn't it be eight checkmark?
The reason you see three checkmarks instead of eight is because the student is a sophomore and it is either a summer term or a spring term. So the student who is a Bonner scholar should only at that point have three checkmarks or ticks because it is populated based on the terms that they are Bonner scholars. Not the overall term this is to address multiple scenario, if a Bonner student decides to drop out of the program there won't be unnecessary populated terms, if they decide to graduate early, the populating of the checkmark will not show a total checkmark at all but only show the checkmarks when they are Bonner scholars and importantly the CELTS department doesn't care about future certification requirment their concern more is if the student have done the previous and present requirement. That is why the populating of checkmark is based on every term they stay in the program or college.

Why is Summer Term move forward to Fall term?
The reason we have a condition where we manually assigned the current term if its summer term to fall term all the time is because if the celts admin is checking this during the summer term we don't want summer term to be considered towards the overall term which will make it from maximum 8 checkmark to 11 checkmark and no Bonner program student is present during summer so it is more reasonable to show that there is a cross for next term then the summer term to always inform the admin about it.

I hope these questions might help and if you want to confirm the logic of it you can definitely refer to the test where the logic is tested in multiple scenario with multiple class levels and terms.