feat: Add back missing elements from merge PR #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix stack-overflow in Error's Display impl Also removed some deprecated impls and changed the "reason" string from the debug string to the human-readable message. * Remove unused lifetime param * Use thiserror and improve the details in our error
* Derive Deserialize for APS and sub-structs * Add Client::certificate_parts to support more use cases * Fix stack-overflow in Error's Display impl Also removed some deprecated impls and changed the "reason" string from the debug string to the human-readable message. * Bump to v0.6.2 * Migrate to new maintainers * fix: Adds tcp feature to hyper (reown-com#61) Co-authored-by: Mark Drobnak <[email protected]> Co-authored-by: Julius de Bruijn <[email protected]> Co-authored-by: Julius de Bruijn <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Rich Neswold <[email protected]> Co-authored-by: Alex Hortopan <[email protected]> Co-authored-by: Harry Bairstow <[email protected]> Co-authored-by: Austin Evans <[email protected]>
Most changes have been captured in this PR, however some might have been missed if so please open a new PR and I'll review ASAP Co-authored-by: Mark Drobnak <[email protected]> Co-authored-by: Julius de Bruijn <[email protected]> Co-authored-by: Julius de Bruijn <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Rich Neswold <[email protected]> Co-authored-by: Alex Hortopan <[email protected]> Co-authored-by: Harry Bairstow <[email protected]> Co-authored-by: Austin Evans <[email protected]> Co-authored-by: Harry Bairstow <[email protected]>
Looks like the `certificate_parts` (which builds the AlpnConnector based on existing certificate component parts) went missing from the original merged PR. In addition, I've added a line to `Cargo.toml` to set the minimum rust version to 1.60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the
certificate_parts(which builds the AlpnConnectorbased on existing certificate component parts) went missing from
the original merged PR.
In addition, I've added a line to
Cargo.tomlto set the minimumrust version to 1.60
Issue: SYNC-3732