Support JIT experience during Sign-In in msal-browser/custom_auth flows #8051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR merges branch custom-auth/jiashen/jit into dev. Summary: - Support JIT experience during Sign-In in msal-browser/custom_auth flows - Add .github Copilot instructions and custom_auth instructions files
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for JIT (Just-In-Time) authentication method registration during sign-in flows in the msal-browser custom_auth module. The implementation adds functionality to handle scenarios where users need to register additional authentication methods after successful password authentication.
Key Changes
- Added new JIT client and related infrastructure for handling authentication method registration
- Integrated JIT support into existing sign-in, sign-up, and reset password flows
- Added comprehensive test coverage for the new JIT functionality including integration tests
Reviewed Changes
Copilot reviewed 72 out of 72 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Test files (*.spec.ts) | Added mock implementations for registerApiClient and jitClient, updated existing tests to include JIT parameter passing |
| SignInClient.ts | Enhanced to handle JIT required errors and return appropriate results for authentication method registration |
| State files | Updated to include jitClient parameter and handle JIT transitions between states |
| Result files | Modified to support new JIT state types and type guards |
| Index exports | Added new JIT-related types and classes to public API |
lib/msal-browser/src/custom_auth/sign_in/interaction_client/SignInClient.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges branch custom-auth/jiashen/jit into dev. Summary: