[TCGC] Support array encode on model property #3583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadelesh
requested review from
bterlson,
iscai-msft,
joheredi,
lmazuel,
m-nash,
markcowl,
srnagar and
timotheeguerin
as code owners
Collaborator
|
All changed packages have been documented.
Show changes
|
commit: |
Collaborator
|
You can try these changes here
|
lirenhe
reviewed
Nov 28, 2025
| strictEqual(prop.type, modelProp.type); | ||
| }); | ||
|
|
||
| it("array with encode", async () => { |
Member
There was a problem hiding this comment.
Can we add more test on this? I think we only support array of string to have this encoding. Shall we report error/warning if this is used on other types?
Member
Author
There was a problem hiding this comment.
I hope TypeSpec core could have such lint. I left comment in the original PR of core.
Member
There was a problem hiding this comment.
Thanks, could you provide the link of that comment here? This PR is good to go but we need to confirm with TypeSpec team about where the check shall happen.
lirenhe
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #3534