-
Notifications
You must be signed in to change notification settings - Fork 65
Remove single service restriction arm #3572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove single service restriction arm #3572
Conversation
commit: |
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
| @armProviderNamespace | ||
| namespace Microsoft.ServiceA { | ||
| model ResA is TrackedResource<{}> { | ||
| @key @segment("foos") @path name: string; | ||
| } | ||
| } | ||
| @armProviderNamespace | ||
| namespace Microsoft.ServiceB { | ||
| model ResB is TrackedResource<{}> { | ||
| @key @segment("foos") @path name: string; | ||
| } | ||
| } | ||
| `); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so how would it behave if we have two parts with the same provider namespace but with different api version enum? this case happen in compute.
Do we have to do something like this?
@providerNamespace("Microsoft.Compute")
@versioned(VMVersions)
namespace Microsoft.Compute.Vms {}
@providerNamespace("Microsoft.Compute")
@versioned(DiskVersions)
namespace Microsoft.Compute.Disks {}
and if we have to do it in the above way, we might not be able to just put them into the one client.tsp without changing their specs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that would be how to do it I asssume playground
| } | ||
| `); | ||
|
|
||
| const resources = getArmResources(program); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a plan that we deprecate this API.
Should we use resolveArmResources instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hhm maybe but this is what all the tests in this file are using and I don't think it will fully go away(at least internally) as this is just the low level accessor
fix #3555