Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create additional output in LZ virtualnetwork submodule to enable referring to VNET names in configuration #438

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

TYYBG
Copy link

@TYYBG TYYBG commented Jan 22, 2025

Overview/summary

Additional output in both virtualnetwork and main module will make it possible to refer to VNETs created in lz_vending module by name. This in turn will make it possible to create subnets within those VNETs in the same configuration file.

This PR fixes/adds/changes/removes

Adds two outputs.

Breaking changes

N/A.

Testing evidence

405774584-d60136a2-1711-48a4-adf4-eff4e02ad1cf

If I run the terraform plan with the config above and try to create a subnet it is impossible to refer to previously created VNETS (below) by name regardless of what's in 'virtual_network_name'

image

With outputs I am able to create subnets within VNETs created by module:

image

As part of this pull request I have

  • [v] Checked for duplicate Pull Requests
  • [V] Associated it with relevant issues, for tracking and closure.
  • Run and make fmt & make docs to format your code and update documentation.
  • [V] Created unit and deployment tests and provided evidence.
  • [V] Updated relevant and associated documentation.

TYYBG added 5 commits January 22, 2025 20:41
Update outputs.tf in virtualnetwork submodule
Update locals.tf in lz_vending module
Update outputs.tf in lz_vending module
@TYYBG
Copy link
Author

TYYBG commented Jan 22, 2025

@TYYBG please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant